Issue 4721044: code review 4721044: go: require { } around else block

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4721044: code review 4721044: go: require { } around else block (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by rsc

Modified:
13 years, 8 months ago

Reviewers:
ken3

CC:
gri, ken2, r, golang-dev

Visibility:
Public.

go: require { } around else block

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
M	doc/go_spec.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/go.y	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/if.go	View	1	2 chunks	+9 lines, -5 lines	0 comments	Download

Total messages: 4

rsc

Hello gri, ken2, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-07-14 20:57:07 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=43f78423340b *** go: require { } around else block R=gri, ken, r ...

13 years, 8 months ago (2011-07-14 21:15:57 UTC) #3

lgtm

actually, it looks completely awful to me.