Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(150)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4715041: code review 4715041: go/printer: changed max. number of newlines from 3 to 2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by gri
Modified:
13 years, 8 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

go/printer: changed max. number of newlines from 3 to 2 manual changes in src/pkg/go/printer, src/cmd/gofix/signal_test.go (cd src/cmd/gofix/testdata; gofmt -w *.in *.out) (cd src/pkg/go/printer; gotest -update) gofmt -w misc src runs all tests

Patch Set 1 #

Patch Set 2 : diff -r 8c249e90b83a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1be79eea166c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 1be79eea166c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r dd24571e45dc https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r fe1828189f20 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r fe1828189f20 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 43f78423340b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2005 lines) Patch
M misc/cgo/gmp/gmp.go View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/cmd/ebnflint/ebnflint.go View 1 2 chunks +0 lines, -6 lines 0 comments Download
M src/cmd/godoc/codewalk.go View 1 12 chunks +0 lines, -12 lines 0 comments Download
M src/cmd/godoc/dirtrees.go View 1 12 chunks +0 lines, -16 lines 0 comments Download
M src/cmd/godoc/filesystem.go View 1 2 3 4 5 6 chunks +0 lines, -11 lines 0 comments Download
M src/cmd/godoc/format.go View 1 14 chunks +0 lines, -15 lines 0 comments Download
M src/cmd/godoc/godoc.go View 1 52 chunks +0 lines, -62 lines 0 comments Download
M src/cmd/godoc/index.go View 1 38 chunks +0 lines, -56 lines 0 comments Download
M src/cmd/godoc/main.go View 1 2 3 4 5 7 chunks +0 lines, -9 lines 0 comments Download
M src/cmd/godoc/mapping.go View 1 8 chunks +0 lines, -10 lines 0 comments Download
M src/cmd/godoc/parser.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/godoc/snippet.go View 1 5 chunks +0 lines, -6 lines 0 comments Download
M src/cmd/godoc/spec.go View 1 11 chunks +0 lines, -14 lines 0 comments Download
M src/cmd/godoc/utils.go View 1 7 chunks +0 lines, -8 lines 0 comments Download
M src/cmd/godoc/zip.go View 1 2 3 4 5 9 chunks +0 lines, -17 lines 0 comments Download
M src/cmd/gofix/oserrorstring.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gofix/signal_test.go View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M src/cmd/gofix/sorthelpers.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gofix/sortslice.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gofix/testdata/reflect.asn1.go.in View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gofix/testdata/reflect.asn1.go.out View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gofix/testdata/reflect.datafmt.go.in View 1 2 3 15 chunks +0 lines, -21 lines 0 comments Download
M src/cmd/gofix/testdata/reflect.datafmt.go.out View 1 2 3 15 chunks +0 lines, -21 lines 0 comments Download
M src/cmd/gofix/testdata/reflect.decode.go.in View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M src/cmd/gofix/testdata/reflect.decode.go.out View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M src/cmd/gofix/testdata/reflect.dnsmsg.go.in View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M src/cmd/gofix/testdata/reflect.dnsmsg.go.out View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M src/cmd/gofix/testdata/reflect.print.go.in View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gofix/testdata/reflect.print.go.out View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gofix/testdata/reflect.scan.go.in View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M src/cmd/gofix/testdata/reflect.scan.go.out View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M src/cmd/gofmt/gofmt.go View 1 10 chunks +0 lines, -14 lines 0 comments Download
M src/cmd/gofmt/gofmt_test.go View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/cmd/gofmt/rewrite.go View 1 9 chunks +0 lines, -10 lines 0 comments Download
M src/cmd/gofmt/simplify.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/cmd/goinstall/main.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gotype/gotype.go View 1 8 chunks +0 lines, -12 lines 0 comments Download
M src/cmd/gotype/gotype_test.go View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/cmd/govet/govet.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/hgpatch/main.go View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/pkg/archive/tar/reader_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/asn1/asn1.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/big/arith.go View 1 16 chunks +0 lines, -17 lines 0 comments Download
M src/pkg/big/arith_test.go View 1 17 chunks +0 lines, -18 lines 0 comments Download
M src/pkg/big/calibrate_test.go View 1 3 chunks +0 lines, -4 lines 0 comments Download
M src/pkg/big/hilbert_test.go View 1 11 chunks +0 lines, -13 lines 0 comments Download
M src/pkg/big/int.go View 1 41 chunks +0 lines, -45 lines 0 comments Download
M src/pkg/big/int_test.go View 1 65 chunks +0 lines, -71 lines 0 comments Download
M src/pkg/big/nat.go View 1 42 chunks +0 lines, -48 lines 0 comments Download
M src/pkg/big/nat_test.go View 1 30 chunks +0 lines, -60 lines 0 comments Download
M src/pkg/big/rat.go View 1 24 chunks +0 lines, -28 lines 0 comments Download
M src/pkg/big/rat_test.go View 1 12 chunks +0 lines, -12 lines 0 comments Download
M src/pkg/bufio/bufio.go View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/pkg/bufio/bufio_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/bytes/buffer_test.go View 1 15 chunks +0 lines, -17 lines 0 comments Download
M src/pkg/bytes/bytes.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/bytes/bytes_test.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/compress/flate/deflate_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/container/heap/heap.go View 1 6 chunks +0 lines, -6 lines 0 comments Download
M src/pkg/container/heap/heap_test.go View 1 7 chunks +0 lines, -9 lines 0 comments Download
M src/pkg/container/ring/ring.go View 1 8 chunks +0 lines, -9 lines 0 comments Download
M src/pkg/container/ring/ring_test.go View 1 10 chunks +0 lines, -10 lines 0 comments Download
M src/pkg/container/vector/defs.go View 1 2 chunks +0 lines, -8 lines 0 comments Download
M src/pkg/container/vector/intvector.go View 1 11 chunks +0 lines, -20 lines 0 comments Download
M src/pkg/container/vector/intvector_test.go View 1 13 chunks +0 lines, -13 lines 0 comments Download
M src/pkg/container/vector/nogen_test.go View 1 4 chunks +0 lines, -9 lines 0 comments Download
M src/pkg/container/vector/numbers_test.go View 1 7 chunks +0 lines, -8 lines 0 comments Download
M src/pkg/container/vector/stringvector.go View 1 11 chunks +0 lines, -20 lines 0 comments Download
M src/pkg/container/vector/stringvector_test.go View 1 13 chunks +0 lines, -13 lines 0 comments Download
M src/pkg/container/vector/vector.go View 1 11 chunks +0 lines, -20 lines 0 comments Download
M src/pkg/container/vector/vector_test.go View 1 13 chunks +0 lines, -13 lines 0 comments Download
M src/pkg/crypto/ocsp/ocsp.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/crypto/openpgp/canonical_text_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/crypto/openpgp/packet/encrypted_key_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/crypto/openpgp/s2k/s2k_test.go View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/pkg/crypto/tls/handshake_server_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/crypto/tls/key_agreement.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/crypto/x509/verify.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/csv/reader.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/debug/dwarf/type_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/debug/elf/elf.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/debug/pe/file.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/ebnf/ebnf.go View 1 9 chunks +0 lines, -10 lines 0 comments Download
M src/pkg/ebnf/ebnf_test.go View 1 6 chunks +0 lines, -8 lines 0 comments Download
M src/pkg/ebnf/parser.go View 1 12 chunks +0 lines, -13 lines 0 comments Download
M src/pkg/encoding/base32/base32_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/encoding/hex/hex.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/exec/exec_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/exp/datafmt/datafmt.go View 1 15 chunks +0 lines, -21 lines 0 comments Download
M src/pkg/exp/datafmt/datafmt_test.go View 1 19 chunks +0 lines, -21 lines 0 comments Download
M src/pkg/exp/datafmt/parser.go View 1 15 chunks +0 lines, -17 lines 0 comments Download
M src/pkg/exp/regexp/syntax/parse.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/exp/regexp/syntax/prog.go View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/exp/template/funcs.go View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/exp/template/parse.go View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/exp/template/set_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/expvar/expvar.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/fmt/fmt_test.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/fmt/print.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/fmt/scan.go View 1 3 chunks +0 lines, -4 lines 0 comments Download
M src/pkg/go/ast/ast.go View 1 34 chunks +0 lines, -42 lines 0 comments Download
M src/pkg/go/ast/filter.go View 1 18 chunks +0 lines, -18 lines 0 comments Download
M src/pkg/go/ast/print.go View 1 6 chunks +0 lines, -9 lines 0 comments Download
M src/pkg/go/ast/print_test.go View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/pkg/go/ast/resolve.go View 1 4 chunks +0 lines, -7 lines 0 comments Download
M src/pkg/go/ast/scope.go View 1 9 chunks +0 lines, -11 lines 0 comments Download
M src/pkg/go/ast/walk.go View 1 4 chunks +0 lines, -7 lines 0 comments Download
M src/pkg/go/doc/comment.go View 1 10 chunks +0 lines, -12 lines 0 comments Download
M src/pkg/go/doc/doc.go View 1 31 chunks +0 lines, -33 lines 0 comments Download
M src/pkg/go/parser/interface.go View 1 7 chunks +0 lines, -8 lines 0 comments Download
M src/pkg/go/parser/parser.go View 1 88 chunks +0 lines, -99 lines 0 comments Download
M src/pkg/go/parser/parser_test.go View 1 7 chunks +0 lines, -9 lines 0 comments Download
M src/pkg/go/printer/nodes.go View 1 37 chunks +0 lines, -41 lines 0 comments Download
M src/pkg/go/printer/performance_test.go View 1 2 chunks +0 lines, -4 lines 0 comments Download
M src/pkg/go/printer/printer.go View 1 33 chunks +1 line, -36 lines 0 comments Download
M src/pkg/go/printer/printer_test.go View 1 7 chunks +0 lines, -10 lines 0 comments Download
M src/pkg/go/printer/testdata/comments.golden View 1 2 9 chunks +0 lines, -10 lines 0 comments Download
M src/pkg/go/printer/testdata/comments.x View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/go/printer/testdata/declarations.golden View 1 2 19 chunks +0 lines, -22 lines 0 comments Download
M src/pkg/go/printer/testdata/expressions.golden View 1 2 20 chunks +0 lines, -23 lines 0 comments Download
M src/pkg/go/printer/testdata/expressions.raw View 1 2 20 chunks +0 lines, -23 lines 0 comments Download
M src/pkg/go/printer/testdata/parser.go View 1 88 chunks +0 lines, -99 lines 0 comments Download
M src/pkg/go/printer/testdata/statements.golden View 1 2 15 chunks +0 lines, -20 lines 0 comments Download
M src/pkg/go/scanner/errors.go View 1 10 chunks +0 lines, -15 lines 0 comments Download
M src/pkg/go/scanner/scanner.go View 1 18 chunks +0 lines, -22 lines 0 comments Download
M src/pkg/go/scanner/scanner_test.go View 1 17 chunks +0 lines, -21 lines 0 comments Download
M src/pkg/go/token/position.go View 1 25 chunks +0 lines, -33 lines 0 comments Download
M src/pkg/go/token/position_test.go View 1 9 chunks +0 lines, -9 lines 0 comments Download
M src/pkg/go/token/token.go View 1 8 chunks +0 lines, -8 lines 0 comments Download
M src/pkg/go/typechecker/scope.go View 1 3 chunks +0 lines, -6 lines 0 comments Download
M src/pkg/go/typechecker/type.go View 1 5 chunks +0 lines, -7 lines 0 comments Download
M src/pkg/go/typechecker/typechecker.go View 1 14 chunks +0 lines, -20 lines 0 comments Download
M src/pkg/go/typechecker/typechecker_test.go View 1 4 chunks +0 lines, -5 lines 0 comments Download
M src/pkg/go/typechecker/universe.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/go/types/check.go View 1 4 chunks +0 lines, -7 lines 0 comments Download
M src/pkg/go/types/check_test.go View 1 8 chunks +0 lines, -9 lines 0 comments Download
M src/pkg/go/types/const.go View 1 11 chunks +0 lines, -15 lines 0 comments Download
M src/pkg/go/types/exportdata.go View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/pkg/go/types/gcimporter.go View 1 37 chunks +0 lines, -39 lines 0 comments Download
M src/pkg/go/types/gcimporter_test.go View 1 5 chunks +0 lines, -5 lines 0 comments Download
M src/pkg/go/types/testdata/exports.go View 1 3 chunks +0 lines, -5 lines 0 comments Download
M src/pkg/go/types/types.go View 1 10 chunks +0 lines, -18 lines 0 comments Download
M src/pkg/go/types/universe.go View 1 4 chunks +0 lines, -7 lines 0 comments Download
M src/pkg/gob/codec_test.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/gob/debug.go View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/pkg/http/cgi/host_test.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/http/client.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/http/triv.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/http/url.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/index/suffixarray/qsufsort.go View 1 4 chunks +0 lines, -4 lines 0 comments Download
M src/pkg/index/suffixarray/suffixarray.go View 1 4 chunks +0 lines, -7 lines 0 comments Download
M src/pkg/index/suffixarray/suffixarray_test.go View 1 7 chunks +0 lines, -9 lines 0 comments Download
M src/pkg/io/ioutil/ioutil_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/json/decode.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/math/acosh.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/math/asin.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/math/asinh.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/math/atanh.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/math/erf.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/math/exp_port.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/math/expm1.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/math/floor.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/math/fmod.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/math/log1p.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/math/sin.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/math/sinh.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/math/tan.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/math/tanh.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/mime/multipart/multipart.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/net/dnsclient_unix.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/net/dnsmsg.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/net/fd_windows.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/net/interface_windows.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/net/ipraw_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/os/env_unix.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/os/file_plan9.go View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/os/inotify/inotify_linux.go View 1 6 chunks +0 lines, -7 lines 0 comments Download
M src/pkg/os/inotify/inotify_linux_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/os/os_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/os/path.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/os/proc.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/os/stat_plan9.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/os/sys_linux.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/os/sys_plan9.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/os/time.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/reflect/all_test.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/reflect/type.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/rpc/client.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/rpc/server.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/scanner/scanner.go View 1 26 chunks +0 lines, -30 lines 0 comments Download
M src/pkg/scanner/scanner_test.go View 1 20 chunks +0 lines, -23 lines 0 comments Download
M src/pkg/sort/search.go View 1 4 chunks +0 lines, -6 lines 0 comments Download
M src/pkg/sort/search_test.go View 1 7 chunks +0 lines, -8 lines 0 comments Download
M src/pkg/sort/sort.go View 1 6 chunks +0 lines, -6 lines 0 comments Download
M src/pkg/sort/sort_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/strconv/atoi.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/strings/reader.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/strings/strings.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/strings/strings_test.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/sync/mutex_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/syscall/exec_unix.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/syscall/syscall_darwin.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/syscall/syscall_freebsd.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/syscall/syscall_plan9.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_unix.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/syscall/zerrors_darwin_386.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/syscall/zerrors_darwin_amd64.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/syscall/zerrors_freebsd_386.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/syscall/zerrors_freebsd_amd64.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/syscall/zerrors_linux_386.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/syscall/zerrors_linux_amd64.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/syscall/zerrors_linux_arm.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/syscall/zerrors_plan9_386.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/tabwriter/tabwriter.go View 1 19 chunks +0 lines, -25 lines 0 comments Download
M src/pkg/tabwriter/tabwriter_test.go View 1 6 chunks +0 lines, -10 lines 0 comments Download
M src/pkg/template/template_test.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/testing/iotest/reader.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/testing/testing.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/time/zoneinfo_unix.go View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/pkg/unicode/casetables.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/unicode/maketables.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/unicode/tables.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/websocket/server.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/xml/xml.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/xml/xml_test.go View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3
gri
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-07-14 20:24:58 UTC) #1
rsc
LGTM
13 years, 8 months ago (2011-07-14 21:13:52 UTC) #2
gri
13 years, 8 months ago (2011-07-14 21:39:45 UTC) #3 
*** Submitted as http://code.google.com/p/go/source/detail?r=248b21b9428b ***

go/printer: changed max. number of newlines from 3 to 2

manual changes in src/pkg/go/printer, src/cmd/gofix/signal_test.go
(cd src/cmd/gofix/testdata; gofmt -w *.in *.out)
(cd src/pkg/go/printer; gotest -update)
gofmt -w misc src

runs all tests

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4715041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b