Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Issue 4699041: code review 4699041: go_tutorial: change the way it's generated. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by r
Modified:
13 years, 8 months ago
Reviewers:
CC:
golang-dev, dsymonds, adg
Visibility:
Public.

Description

go_tutorial: change the way it's generated. No longer do we generate HTML from it; instead the input file is already in HTML but has template invocations to extract programs from other files. Delete htmlgen, which is no longer needed. Add tmpltohtml, which runs the templating code.

Patch Set 1 #

Patch Set 2 : diff -r a5b801874645 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a5b801874645 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a5b801874645 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r 2131931a8b68 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1221 lines, -1299 lines) Patch
M doc/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M doc/go_tutorial.html View 41 chunks +50 lines, -50 lines 0 comments Download
A doc/go_tutorial.tmpl View 1 chunk +990 lines, -0 lines 0 comments Download
R doc/go_tutorial.txt View 1 chunk +0 lines, -932 lines 0 comments Download
R doc/htmlgen.go View 1 chunk +0 lines, -312 lines 0 comments Download
M doc/makehtml View 2 chunks +3 lines, -3 lines 0 comments Download
A doc/tmpltohtml.go View 1 2 3 4 1 chunk +176 lines, -0 lines 0 comments Download

Messages

Total messages: 5
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-07-12 03:31:18 UTC) #1
dsymonds
You haven't added tmpltohtml to the CL.
13 years, 8 months ago (2011-07-12 03:35:23 UTC) #2
r
Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 8 months ago (2011-07-12 03:46:09 UTC) #3
adg
LGTM http://codereview.appspot.com/4699041/diff/8001/doc/tmpltohtml.go File doc/tmpltohtml.go (right): http://codereview.appspot.com/4699041/diff/8001/doc/tmpltohtml.go#newcode48 doc/tmpltohtml.go:48: input := contents(name) Just use ParseFile instead. http://codereview.appspot.com/4699041/diff/8001/doc/tmpltohtml.go#newcode143 ...
13 years, 8 months ago (2011-07-13 00:05:56 UTC) #4
r
13 years, 8 months ago (2011-07-13 03:20:15 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=f4ae9298e4fc ***

go_tutorial: change the way it's generated.
No longer do we generate HTML from it; instead the input
file is already in HTML but has template invocations to
extract programs from other files.
Delete htmlgen, which is no longer needed.
Add tmpltohtml, which runs the templating code.

R=golang-dev, dsymonds, adg
CC=golang-dev
http://codereview.appspot.com/4699041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b