Issue 4698041: code review 4698041: [release-branch.r58] runtime/cgo: fix for OS X 10.7

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4698041: code review 4698041: [release-branch.r58] runtime/cgo: fix for OS X 10.7 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by rsc

Modified:
12 years, 9 months ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

[release-branch.r58] runtime/cgo: fix for OS X 10.7 ««« CL 4603057 / 0905a2ca94c6 runtime/cgo: fix for OS X 10.7 Correct a few error messages (libcgo -> runtime/cgo) and delete old nacl_386.c file too. Fixes issue 1657. R=iant CC=golang-dev http://codereview.appspot.com/4603057 »»»

Patch Set 1 #

Patch Set 2 : diff -r 1b38d90eebcd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1b38d90eebcd https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -94 lines)			Patch
M	src/pkg/runtime/cgo/darwin_386.c	View	1	3 chunks	+36 lines, -36 lines	0 comments	Download
M	src/pkg/runtime/cgo/darwin_amd64.c	View	1	2 chunks	+27 lines, -38 lines	0 comments	Download
R	src/pkg/runtime/cgo/nacl_386.c	View	1	1 chunk	+0 lines, -19 lines	0 comments	Download
M	src/pkg/runtime/cgo/util.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2011-07-12 03:09:56 UTC) #1

rsc

12 years, 9 months ago (2011-07-12 03:38:07 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=bf17e96b6582 ***

[release-branch.r58] runtime/cgo: fix for OS X 10.7

««« CL 4603057 / 0905a2ca94c6
runtime/cgo: fix for OS X 10.7

Correct a few error messages (libcgo -> runtime/cgo)
and delete old nacl_386.c file too.

Fixes issue 1657.

R=iant
CC=golang-dev
http://codereview.appspot.com/4603057
»»»

R=adg
CC=golang-dev
http://codereview.appspot.com/4698041

Expand All Messages | Collapse All Messages