Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1312)

Issue 4695047: code review 4695047: exp/eval, exp/ogle: remove packages eval and ogle (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by gri
Modified:
13 years, 8 months ago
Reviewers:
CC:
golang-dev, r, rsc
Visibility:
Public.

Description

exp/eval, exp/ogle: remove packages eval and ogle An externally maintained version of exp/eval can be found at: https://bitbucket.org/binet/go-eval/ .

Patch Set 1 #

Patch Set 2 : diff -r 8c249e90b83a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8c249e90b83a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8c249e90b83a https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 7f39a0541e03 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12795 lines) Patch
M src/pkg/Makefile View 1 1 chunk +0 lines, -1 line 0 comments Download
R src/pkg/exp/eval/Makefile View 1 1 chunk +0 lines, -37 lines 0 comments Download
R src/pkg/exp/eval/abort.go View 1 1 chunk +0 lines, -85 lines 0 comments Download
R src/pkg/exp/eval/bridge.go View 1 1 chunk +0 lines, -164 lines 0 comments Download
R src/pkg/exp/eval/compiler.go View 1 1 chunk +0 lines, -92 lines 0 comments Download
R src/pkg/exp/eval/eval_test.go View 1 1 chunk +0 lines, -263 lines 0 comments Download
R src/pkg/exp/eval/expr.go View 1 1 chunk +0 lines, -2015 lines 0 comments Download
R src/pkg/exp/eval/expr1.go View 1 1 chunk +0 lines, -1874 lines 0 comments Download
R src/pkg/exp/eval/expr_test.go View 1 1 chunk +0 lines, -355 lines 0 comments Download
R src/pkg/exp/eval/func.go View 1 1 chunk +0 lines, -70 lines 0 comments Download
R src/pkg/exp/eval/gen.go View 1 1 chunk +0 lines, -375 lines 0 comments Download
R src/pkg/exp/eval/main.go View 1 1 chunk +0 lines, -93 lines 0 comments Download
R src/pkg/exp/eval/scope.go View 1 1 chunk +0 lines, -207 lines 0 comments Download
R src/pkg/exp/eval/stmt.go View 1 1 chunk +0 lines, -1299 lines 0 comments Download
R src/pkg/exp/eval/stmt_test.go View 1 1 chunk +0 lines, -343 lines 0 comments Download
R src/pkg/exp/eval/test.bash View 1 1 chunk +0 lines, -35 lines 0 comments Download
R src/pkg/exp/eval/type.go View 1 1 chunk +0 lines, -1252 lines 0 comments Download
R src/pkg/exp/eval/typec.go View 1 1 chunk +0 lines, -409 lines 0 comments Download
R src/pkg/exp/eval/value.go View 1 1 chunk +0 lines, -586 lines 0 comments Download
R src/pkg/exp/eval/world.go View 1 1 chunk +0 lines, -188 lines 0 comments Download
R src/pkg/exp/ogle/Makefile View 1 1 chunk +0 lines, -29 lines 0 comments Download
R src/pkg/exp/ogle/abort.go View 1 1 chunk +0 lines, -35 lines 0 comments Download
R src/pkg/exp/ogle/arch.go View 1 1 chunk +0 lines, -125 lines 0 comments Download
R src/pkg/exp/ogle/cmd.go View 1 1 chunk +0 lines, -373 lines 0 comments Download
R src/pkg/exp/ogle/event.go View 1 1 chunk +0 lines, -280 lines 0 comments Download
R src/pkg/exp/ogle/frame.go View 1 1 chunk +0 lines, -212 lines 0 comments Download
R src/pkg/exp/ogle/goroutine.go View 1 1 chunk +0 lines, -117 lines 0 comments Download
R src/pkg/exp/ogle/main.go View 1 1 chunk +0 lines, -9 lines 0 comments Download
R src/pkg/exp/ogle/process.go View 1 1 chunk +0 lines, -521 lines 0 comments Download
R src/pkg/exp/ogle/rruntime.go View 1 1 chunk +0 lines, -271 lines 0 comments Download
R src/pkg/exp/ogle/rtype.go View 1 1 chunk +0 lines, -288 lines 0 comments Download
R src/pkg/exp/ogle/rvalue.go View 1 1 chunk +0 lines, -515 lines 0 comments Download
R src/pkg/exp/ogle/vars.go View 1 1 chunk +0 lines, -272 lines 0 comments Download
M src/run.bash View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5
gri
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-07-12 18:47:00 UTC) #1
r
LGTM
13 years, 8 months ago (2011-07-12 23:52:45 UTC) #2
rsc
LGTM
13 years, 8 months ago (2011-07-13 00:31:38 UTC) #3
gri
Hello golang-dev@googlegroups.com, r@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-07-13 16:40:51 UTC) #4
gri
13 years, 8 months ago (2011-07-13 16:40:58 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=8acd9d76c51d ***

exp/eval, exp/ogle: remove packages eval and ogle

An externally maintained version of exp/eval can
be found at: https://bitbucket.org/binet/go-eval/ .

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/4695047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b