Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(210)

Issue 4684044: code review 4684044: http: update triv.go with gofix (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by andybalholm
Modified:
13 years, 8 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

http: update triv.go with gofix Sample code in triv.go wouldn't compile because it didn't use the new FileSystem interface. This was discussed on golang-nuts on July 7. https://groups.google.com/forum/#!topic/golang-nuts/NMhZk3Ft_Vc

Patch Set 1 #

Patch Set 2 : diff -r eb3f582c92d5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r eb3f582c92d5 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/http/triv.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
andybalholm
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-07-09 21:25:58 UTC) #1
bradfitz
LGTM On Sat, Jul 9, 2011 at 2:25 PM, <andybalholm@gmail.com> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
13 years, 8 months ago (2011-07-09 22:09:34 UTC) #2
bradfitz
13 years, 8 months ago (2011-07-09 22:10:43 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=bc3f699ec6f4 ***

http: update triv.go with gofix

Sample code in triv.go wouldn't compile because it didn't use the new
FileSystem interface.
This was discussed on golang-nuts on July 7.
https://groups.google.com/forum/#!topic/golang-nuts/NMhZk3Ft_Vc

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/4684044

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b