Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1995)

Issue 4675041: code review 4675041: doc: don't specify make target for working on windwos. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by mattn
Modified:
13 years, 9 months ago
Reviewers:
CC:
golang-dev_googlecode.com, adg, rsc, golang-dev
Visibility:
Public.

Description

doc: don't specify make target for working on windwos. makehtml does not work on windows.

Patch Set 1 #

Patch Set 2 : diff -r 67b160cd5fa4 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 67b160cd5fa4 http://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M doc/makehtml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
mattn
Hello golang-dev@googlecode.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg/
13 years, 9 months ago (2011-07-04 07:06:20 UTC) #1
adg
Is this even in run.bash? Why does it matter if it works on Windows?
13 years, 9 months ago (2011-07-05 00:26:47 UTC) #2
adg
On 5 July 2011 11:03, mattn <mattn.jp@gmail.com> wrote: > If you are thinking that it ...
13 years, 9 months ago (2011-07-05 01:07:02 UTC) #3
rsc
> No, I just don't see why Windows users should need to run makehtml. > ...
13 years, 9 months ago (2011-07-11 23:41:03 UTC) #4
rsc
LGTM
13 years, 9 months ago (2011-07-11 23:43:08 UTC) #5
rsc
13 years, 9 months ago (2011-07-12 00:02:36 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=80756338ccf7 ***

doc: don't specify make target for working on windwos.
makehtml does not work on windows.

R=golang-dev, adg, rsc
CC=golang-dev
http://codereview.appspot.com/4675041

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b