Issue 4667041: code review 4667041: http: assume ContentLength 0 on GET requests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4667041: code review 4667041: http: assume ContentLength 0 on GET requests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by bradfitz

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, kevlar

Visibility:
Public.

Description

http: assume ContentLength 0 on GET requests Incremental step in fix for issue 1999

Patch Set 2 : diff -r 0e61fe198e7a https://go.googlecode.com/hg #

Patch Set 3 : diff -r 0e61fe198e7a https://go.googlecode.com/hg #

Patch Set 4 : diff -r 0e61fe198e7a https://go.googlecode.com/hg #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -6 lines)			Patch
	M	src/pkg/http/readrequest_test.go	View	1	2 chunks	+26 lines, -1 line	0 comments	Download
	M	src/pkg/http/transfer.go	View	1	7 chunks	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 9 months ago (2011-06-24 20:16:11 UTC) #1

kevlar

On 2011/06/24 20:16:11, bradfitz wrote: > Hello https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=golang-dev@googlegroups.com (cc: https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=golang-dev@googlegroups.com), > > I'd like you ...

13 years, 9 months ago (2011-06-24 20:43:16 UTC) #2

bradfitz

13 years, 9 months ago (2011-06-24 20:48:17 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=90f9c658e53d ***

http: assume ContentLength 0 on GET requests

Incremental step in fix for issue 1999

R=golang-dev, kevlar
CC=golang-dev
http://codereview.appspot.com/4667041

Expand All Messages | Collapse All Messages