Issue 4650053: code review 4650053: 5c: do not use R9 and R10

Issue 4650053: code review 4650053: 5c: do not use R9 and R10 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by rsc

Modified:
13 years, 8 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

5c: do not use R9 and R10 This program used to use R9 and R10. Now it fails to compile (out of registers). I used to know a simpler test but can't remember it. Learned something new: Rietveld refuses change list descriptions bigger than 10 kB. int sum(int x, int y, int z, int w) { return (((((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))))/ ((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))))% (((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))))/ ((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))))))* ((((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))))/ ((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))))% (((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))))/ ((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))))))* (((((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))))/ ((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))))% (((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))))/ ((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))))))* ((((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))))/ ((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))))% (((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))))/ ((((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w)))| (((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))& ((x*y+z*w|x*y+z*w)^ (x*y+z*w|x*y+z*w))))))) ; }

Patch Set 1 #

Patch Set 2 : diff -r 6adcc9f52615 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7768f924c335 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -26 lines)			Patch
	M	src/cmd/5c/txt.c	View	1	4 chunks	+5 lines, -23 lines	0 comments	Download
	M	src/pkg/runtime/Makefile	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-06-23 03:22:35 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=3bc075e2993d *** 5c: do not use R9 and R10 This program used ...

13 years, 8 months ago (2011-06-23 03:22:47 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=3bc075e2993d ***

5c: do not use R9 and R10

This program used to use R9 and R10.
Now it fails to compile (out of registers).
I used to know a simpler test but can't remember it.

Learned something new: Rietveld refuses change
list descriptions bigger than 10 kB.

int sum(int x, int y, int z, int w) {
        return
        (((((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))%
        (((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))))*
        ((((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))%
        (((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))))*
        (((((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))%
        (((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))))*
        ((((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))%
        (((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))))
        ;
}

R=ken2
CC=golang-dev
http://codereview.appspot.com/4650053

lgtm

Expand All Messages | Collapse All Messages