Issue 4645071: code review 4645071: [release-branch.r58] gofix: fixes for os/signal changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4645071: code review 4645071: [release-branch.r58] gofix: fixes for os/signal changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by adg

Modified:
12 years, 10 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

[release-branch.r58] gofix: fixes for os/signal changes ««« CL 4630056 / 8fe2bc5c3d53 gofix: fixes for os/signal changes Fixes issue 1971. R=adg, rsc CC=golang-dev http://codereview.appspot.com/4630056 Committer: Andrew Gerrand <adg@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r 0a283d21ca1f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0a283d21ca1f https://go.googlecode.com/hg/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+301 lines, -4 lines)			Patch
M	src/cmd/gofix/Makefile	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gofix/fix.go	View	1	3 chunks	+155 lines, -4 lines	0 comments	Download
A	src/cmd/gofix/signal.go	View	1	1 chunk	+49 lines, -0 lines	0 comments	Download
A	src/cmd/gofix/signal_test.go	View	1	1 chunk	+96 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 10 months ago (2011-06-29 06:51:59 UTC) #1

adg

12 years, 10 months ago (2011-06-29 06:57:48 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=131d5b5497dd ***

[release-branch.r58] gofix: fixes for os/signal changes

««« CL 4630056 / 8fe2bc5c3d53
gofix: fixes for os/signal changes

Fixes issue 1971.

R=adg, rsc
CC=golang-dev
http://codereview.appspot.com/4630056

Committer: Andrew Gerrand <adg@golang.org>
»»»

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4645071

Expand All Messages | Collapse All Messages