code review 4645044: 8l: minor fix discovered by lucio

8l: minor fix discovered by lucio

[brainman, 2011-06-17 05:49:57]

Hello lucio.dere@gmail.com, vcc.163@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[brainman, 2011-06-17 05:51:20]

One character changed. Will be funny if I made mistake<g>!

Alex

[bradfitz, 2011-06-17 05:53:56]

LGTM

On Thu, Jun 16, 2011 at 10:49 PM, <alex.brainman@gmail.com> wrote:

> Reviewers: lucio, vcc,
>
> Message:
> Hello lucio.dere@gmail.com, vcc.163@gmail.com (cc:
> golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> 8l: minor fix discovered by lucio
>
> Please review this at
http://codereview.appspot.com/**4645044/<http://codereview.appspot.com/4645044/>
>
> Affected files:
>  M src/cmd/ld/ldpe.c
>
>
> Index: src/cmd/ld/ldpe.c
> ==============================**==============================**=======
> --- a/src/cmd/ld/ldpe.c
> +++ b/src/cmd/ld/ldpe.c
> @@ -371,7 +371,7 @@
>        name = sym->name;
>        if(sym->sclass == IMAGE_SYM_CLASS_STATIC && sym->value == 0) //
> section
>                name = obj->sect[sym->sectnum-1].sym-**>name;
> -       if(strncmp(sym->name, "__imp__", 6) == 0)
> +       if(strncmp(sym->name, "__imp__", 7) == 0)
>                name = &sym->name[7]; // __imp__Name => Name
>        else if(sym->name[0] == '_')
>                name = &sym->name[1]; // _Name => Name
>
>
>

[brainman, 2011-06-17 05:56:06]

*** Submitted as http://code.google.com/p/go/source/detail?r=a60d96c53c59 ***

8l: minor fix discovered by lucio

R=lucio.dere, vcc.163, bradfitz
CC=golang-dev
http://codereview.appspot.com/4645044

[vcc, 2011-06-17 06:09:37]

Thanks for fix this<g>!

2011/6/17  <alex.brainman@gmail.com>:
> One character changed. Will be funny if I made mistake<g>!
>
> Alex
>
> http://codereview.appspot.com/4645044/
>