code review 4641093: syscall: rearrange windows code so 386 and amd64 can sh...

syscall: rearrange windows code so 386 and amd64 can share files

[brainman, 2011-07-06 23:44:31]

Hello golang-dev@googlegroups.com (cc: vcc.163@gmail.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-07-06 23:59:46]

LGTM but please change the first line of the CL desc to

syscall: rearrange windows code so 386 and amd64 can share files

or something like that

http://codereview.appspot.com/4641093/diff/5001/src/pkg/syscall/mkall.sh
File src/pkg/syscall/mkall.sh (right):

http://codereview.appspot.com/4641093/diff/5001/src/pkg/syscall/mkall.sh#newc...
src/pkg/syscall/mkall.sh:160: mkerrors="./mkerrors_windows.sh -f -m32"
is -m32 right here?

[brainman, 2011-07-07 00:16:19]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com, vcc.163@gmail.com),

Please take another look.

[brainman, 2011-07-07 00:16:40]

http://codereview.appspot.com/4641093/diff/5001/src/pkg/syscall/mkall.sh
File src/pkg/syscall/mkall.sh (right):

http://codereview.appspot.com/4641093/diff/5001/src/pkg/syscall/mkall.sh#newc...
src/pkg/syscall/mkall.sh:160: mkerrors="./mkerrors_windows.sh -f -m32"
On 2011/07/06 23:59:46, r wrote:
> is -m32 right here?

I run ./mkall.sh when I update z*_windows* files on my pc (linux/386). But if I
run

./mkerrors_windows.sh -f -m64

I get

_errors.c:1: sorry, unimplemented: 64-bit mode not compiled in

For what ./mkerrors_windows.sh does, I think, this flag (-m32/-m64) is
irrelevant, but I don't want to start changing things here.

[r, 2011-07-07 00:17:07]

LGTM

[brainman, 2011-07-07 00:40:54]

*** Submitted as http://code.google.com/p/go/source/detail?r=2ad7567da169 ***

syscall: rearrange windows code so 386 and amd64 can share files

R=golang-dev, r
CC=golang-dev, vcc.163
http://codereview.appspot.com/4641093