Issue 4639053: code review 4639053: build: exclude packages that fail on Plan 9 (for now)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4639053: code review 4639053: build: exclude packages that fail on Plan 9 (for now) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by ality

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

build: exclude packages that fail on Plan 9 (for now) All but two packages depend on net: debug/proc os/signal With this change, we can produce a working build with GOOS=plan9.

Patch Set 2 : diff -r 81b5e5abc179 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 81b5e5abc179 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 81b5e5abc179 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -0 lines)			Patch
	M	src/pkg/Makefile	View	1 2 3	1 chunk	+30 lines, -0 lines	0 comments	Download
	M	src/pkg/runtime/cgo/Makefile	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ality

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-06-20 10:31:43 UTC) #1

exciting! http://codereview.appspot.com/4639053/diff/5001/src/pkg/Makefile File src/pkg/Makefile (right): http://codereview.appspot.com/4639053/diff/5001/src/pkg/Makefile#newcode186 src/pkg/Makefile:186: NOP9BUILD=\ Please call this NOPLAN9BUILD

13 years, 9 months ago (2011-06-20 10:49:33 UTC) #2

ality

PTAL > http://codereview.appspot.com/4639053/diff/5001/src/pkg/Makefile > File src/pkg/Makefile (right): > > http://codereview.appspot.com/4639053/diff/5001/src/pkg/Makefile#newcode186 > src/pkg/Makefile:186: NOP9BUILD=\ > Please ...

13 years, 9 months ago (2011-06-20 10:57:34 UTC) #3

13 years, 9 months ago (2011-06-20 12:23:59 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=40a281c810e2 ***

build: exclude packages that fail on Plan 9 (for now)

All but two packages depend on net:
        debug/proc
        os/signal

With this change, we can produce
a working build with GOOS=plan9.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4639053

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages