Issue 4638050: code review 4638050: ld: don't attempt to build dynamic sections unnecessarily

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4638050: code review 4638050: ld: don't attempt to build dynamic sections unnecessarily (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by niemeyer

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc, gustavo_niemeyer.net

Visibility:
Public.

Description

ld: don't attempt to build dynamic sections unnecessarily This prevents ld from generating zeroed symtab entries for sections that aren't going to be generated because dynamic linkage has been disabled (-d was used or no dynamic libs were seen). Even though they were not explicitly added by doelf, the section creation process was making them reachable again. The windows head is being disconsidered for this because apparently it's not taking into account debug['d']. This makes elflint 0.1% happier.

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/cmd/ld/data.c	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-06-21 04:46:28 UTC) #1

gustavo_niemeyer.net

> Did you check this on the Mac? I haven't run tests on a Mac ...

13 years, 9 months ago (2011-06-21 18:04:06 UTC) #3

rsc

13 years, 9 months ago (2011-06-22 19:12:27 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=eae3ec259a99 ***

ld: don't attempt to build dynamic sections unnecessarily

This prevents ld from generating zeroed symtab entries for
sections that aren't going to be generated because dynamic
linkage has been disabled (-d was used or no dynamic libs
were seen).  Even though they were not explicitly added by
doelf, the section creation process was making them
reachable again.

The windows head is being disconsidered for this because
apparently it's not taking into account debug['d'].

This makes elflint 0.1% happier.

R=golang-dev, rsc, gustavo
CC=golang-dev
http://codereview.appspot.com/4638050

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages