code review 4635092: crypto/tls: fix generate_cert.go

crypto/tls: fix generate_cert.go

Fixes issue 2030.

[agl1, 2011-07-06 14:35:32]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2011-07-06 19:33:06]

LGTM

On Wed, Jul 6, 2011 at 7:35 AM,  <agl@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> crypto/tls: fix generate_cert.go
>
> Fixes issue 2030.
>
> Please review this at http://codereview.appspot.com/4635092/
>
> Affected files:
>  M src/pkg/crypto/tls/generate_cert.go
>
>
> Index: src/pkg/crypto/tls/generate_cert.go
> ===================================================================
> --- a/src/pkg/crypto/tls/generate_cert.go
> +++ b/src/pkg/crypto/tls/generate_cert.go
> @@ -8,8 +8,10 @@
>  package main
>
>  import (
> +       "big"
> +       "crypto/x509/pkix"
> +       "crypto/rand"
>        "crypto/rsa"
> -       "crypto/rand"
>        "crypto/x509"
>        "encoding/pem"
>        "flag"
> @@ -32,8 +34,8 @@
>        now := time.Seconds()
>
>        template := x509.Certificate{
> -               SerialNumber: []byte{0},
> -               Subject: x509.Name{
> +               SerialNumber: new(big.Int).SetInt64(0),
> +               Subject: pkix.Name{
>                        CommonName:   *hostName,
>                        Organization: []string{"Acme Co"},
>                },
>
>
>

[agl1, 2011-07-06 20:22:40]

*** Submitted as http://code.google.com/p/go/source/detail?r=79b50ea0de7c ***

crypto/tls: fix generate_cert.go

Fixes issue 2030.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/4635092