code review 4635053: nacl, tiny: remove vestiges

nacl, tiny: remove vestiges

[rh, 2011-06-18 19:54:44]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-06-18 22:27:11]

LGTM but leaving for rsc. i'm a little nervous about some of the changes inside
the linker, but i think they're ok.

[rsc, 2011-06-20 15:38:59]

The mention in ld/elf.h should stay:
it's a defined constant, just like we list

ELFOSABI_OPENVMS

[rh, 2011-06-20 23:57:08]

Thank you both for the review.

On 2011/06/20 15:38:59, rsc wrote:
> The mention in ld/elf.h should stay:
> it's a defined constant, just like we list
> 
> ELFOSABI_OPENVMS

In the NaCL source code, ELFOSABI_NACL contains the comment " * TODO(sehr): Get
real values approved by the appropriate authorities."
The use of ELFOSABI_NACL at all seems to be an unresolved issue:
http://code.google.com/p/nativeclient/issues/detail?id=564
It seemed better to leave it out for these reasons, but if you disagree, I will
revert the change.

[rsc, 2011-06-21 00:02:08]

> In the NaCL source code, ELFOSABI_NACL contains the comment " *
> TODO(sehr): Get real values approved by the appropriate authorities."
> The use of ELFOSABI_NACL at all seems to be an unresolved issue:
> http://code.google.com/p/nativeclient/issues/detail?id=564
> It seemed better to leave it out for these reasons, but if you disagree,
> I will revert the change.

Sure, let's take it out.

[rh, 2011-06-21 00:14:10]

On 2011/06/21 00:02:08, rsc wrote:
> Sure, let's take it out.

OK, thank you.  PTAL... I think? (synced to tip but no further changes)

[rsc, 2011-06-21 16:02:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=32d60e489410 ***

nacl, tiny: remove vestiges

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/4635053

Committer: Russ Cox <rsc@golang.org>