Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(50)

Issue 4634080: code review 4634080: Fix Windows build; ErrorString->NewError (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by bradfitz
Modified:
13 years, 9 months ago
Reviewers:
CC:
golang-dev, gri
Visibility:
Public.

Description

Fix Windows build; ErrorString->NewError

Patch Set 1 #

Patch Set 2 : diff -r 257fe69c8645 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 257fe69c8645 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 257fe69c8645 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/os/exec_windows.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 9 months ago (2011-06-22 18:27:51 UTC) #1
gri
LGTM - gri On Wed, Jun 22, 2011 at 11:27 AM, <bradfitz@golang.org> wrote: > Reviewers: ...
13 years, 9 months ago (2011-06-22 18:32:06 UTC) #2
bradfitz
13 years, 9 months ago (2011-06-22 18:33:37 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=819e8e4e5740 ***

Fix Windows build; ErrorString->NewError

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/4634080
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b