Issue 4632055: code review 4632055: exec: LookPath should not search %PATH% for files like ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4632055: code review 4632055: exec: LookPath should not search %PATH% for files like ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by brainman

Modified:
13 years, 8 months ago

Reviewers:
rsc

CC:
golang-dev

Visibility:
Public.

exec: LookPath should not search %PATH% for files like c:cmd.exe

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/exec/lp_windows.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-06-23 00:48:13 UTC) #1

brainman

*** Submitted as http://code.google.com/p/go/source/detail?r=7768f924c335 *** exec: LookPath should not search %PATH% for files like c:cmd.exe ...

13 years, 8 months ago (2011-06-23 00:57:00 UTC) #2

rsc

13 years, 8 months ago (2011-06-23 01:25:08 UTC) #3

It's been a long time.  Are you allowed to use : elsewhere in the path,
like foo:bar ?