code review 4630081: net: break up and simplify Dial a bit

net: break up and simplify Dial a bit

No API or functional change.

[bradfitz, 2011-06-29 21:24:33]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-06-29 21:30:02]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[jacekm, 2011-06-29 21:55:13]

http://codereview.appspot.com/4630081/diff/10001/src/pkg/net/dial.go
File src/pkg/net/dial.go (right):

http://codereview.appspot.com/4630081/diff/10001/src/pkg/net/dial.go#newcode25
src/pkg/net/dial.go:25: if err == nil {
It seems more common in Go codebase to handle failure case in
a new block, and the success case in the existing block.

http://codereview.appspot.com/4630081/diff/10001/src/pkg/net/dial.go#newcode64
src/pkg/net/dial.go:64: if err == nil {
Same here.

[bradfitz, 2011-06-29 21:58:15]

Hello golang-dev@googlegroups.com, jacek.masiulaniec@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2011-06-29 21:58:41]

Done.

On Wed, Jun 29, 2011 at 2:55 PM, <Jacek.Masiulaniec@gmail.com> wrote:

>
>
http://codereview.appspot.com/**4630081/diff/10001/src/pkg/**net/dial.go<http...
> File src/pkg/net/dial.go (right):
>
> http://codereview.appspot.com/**4630081/diff/10001/src/pkg/**
>
net/dial.go#newcode25<http://codereview.appspot.com/4630081/diff/10001/src/pkg/net/dial.go#newcode25>
> src/pkg/net/dial.go:25: if err == nil {
> It seems more common in Go codebase to handle failure case in
> a new block, and the success case in the existing block.
>
> http://codereview.appspot.com/**4630081/diff/10001/src/pkg/**
>
net/dial.go#newcode64<http://codereview.appspot.com/4630081/diff/10001/src/pkg/net/dial.go#newcode64>
> src/pkg/net/dial.go:64: if err == nil {
> Same here.
>
>
http://codereview.appspot.com/**4630081/<http://codereview.appspot.com/4630081/>
>

[mikio, 2011-06-30 02:45:21]

LGTM

On Thu, Jun 30, 2011 at 6:58 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Done.
>
> On Wed, Jun 29, 2011 at 2:55 PM, <Jacek.Masiulaniec@gmail.com> wrote:
>>
>> http://codereview.appspot.com/4630081/diff/10001/src/pkg/net/dial.go
>> File src/pkg/net/dial.go (right):
>>
>>
>>
http://codereview.appspot.com/4630081/diff/10001/src/pkg/net/dial.go#newcode25
>> src/pkg/net/dial.go:25: if err == nil {
>> It seems more common in Go codebase to handle failure case in
>> a new block, and the success case in the existing block.
>>
>>
>>
http://codereview.appspot.com/4630081/diff/10001/src/pkg/net/dial.go#newcode64
>> src/pkg/net/dial.go:64: if err == nil {
>> Same here.
>>
>> http://codereview.appspot.com/4630081/
>
>

[rsc, 2011-06-30 02:56:42]

Are there other changes too?
As written resolveNetAddr might as well be inlined
into Dial but maybe you are planning to use it
somewhere else?

[bradfitz, 2011-06-30 03:49:20]

On Wed, Jun 29, 2011 at 7:56 PM, <rsc@golang.org> wrote:

> Are there other changes too?
>

 Observant. :)

As written resolveNetAddr might as well be inlined
> into Dial but maybe you are planning to use it
> somewhere else?


Forthcoming. I suck at hg.

This work as-is?

[rsc, 2011-06-30 04:33:19]

LGTM

On Wed, Jun 29, 2011 at 23:49, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> On Wed, Jun 29, 2011 at 7:56 PM, <rsc@golang.org> wrote:
>>
>> Are there other changes too?
>
>  Observant. :)
>>
>> As written resolveNetAddr might as well be inlined
>> into Dial but maybe you are planning to use it
>> somewhere else?
>
> Forthcoming. I suck at hg.
> This work as-is?

[bradfitz, 2011-06-30 04:56:17]

*** Submitted as http://code.google.com/p/go/source/detail?r=f3daeb861002 ***

net: break up and simplify Dial a bit

No API or functional change.

R=jacek.masiulaniec, mikioh.mikioh, rsc
CC=golang-dev
http://codereview.appspot.com/4630081