Issue 4630072: code review 4630072: http: do TLS handshake explicitly before copying TLS state

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4630072: code review 4630072: http: do TLS handshake explicitly before copying TLS state (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by bradfitz

Modified:
13 years, 9 months ago

Reviewers:
agl1

CC:
golang-dev, rsc

Visibility:
Public.

Description

http: do TLS handshake explicitly before copying TLS state Previously we were snapshotting the TLS state into *Request before we did the HTTP ReadRequest, the first Read of which triggered the TLS handshake implicitly. Fixes issue 1956

Patch Set 1 #

Patch Set 2 : diff -r d647efcd873b https://go.googlecode.com/hg #

Patch Set 3 : diff -r d647efcd873b https://go.googlecode.com/hg #

Patch Set 4 : diff -r e459803932c7 https://go.googlecode.com/hg #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -10 lines)			Patch
	M	src/pkg/http/serve_test.go	View	1	2 chunks	+12 lines, -10 lines	0 comments	Download
	M	src/pkg/http/server.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: agl@golang.org, golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 9 months ago (2011-06-27 17:34:10 UTC) #1

bradfitz

*** Submitted as http://code.google.com/p/go/source/detail?r=29f2e8341299 *** http: do TLS handshake explicitly before copying TLS state Previously ...

13 years, 9 months ago (2011-06-27 17:37:35 UTC) #3

LGTM

Expand All Messages | Collapse All Messages