Issue 4630052: http: write Headers with empty values

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4630052: http: write Headers with empty values (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by bradfitz

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc, r

Visibility:
Public.

Description

http: write Header keys with empty values

Patch Set 1 #

Patch Set 2 : diff -r 7700d209820a https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	src/pkg/http/header.go	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	src/pkg/http/header_test.go	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-06-20 21:24:40 UTC) #1

please add a description to the CL. i'm surprised hg even let this through. -rob

13 years, 9 months ago (2011-06-20 21:26:24 UTC) #3

bradfitz

I messed up and did: $ hg mail -m golang-dev header.go header_test.go Fixed. On Mon, ...

13 years, 9 months ago (2011-06-20 21:34:28 UTC) #4

bradfitz

13 years, 9 months ago (2011-06-20 21:36:12 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=46e644c8a858 ***

http: write Header keys with empty values

R=golang-dev, rsc, r
CC=golang-dev
http://codereview.appspot.com/4630052

Expand All Messages | Collapse All Messages