Issue 4630045: code review 4630045: http: add Server.ListenAndServeTLS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4630045: code review 4630045: http: add Server.ListenAndServeTLS (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by bradfitz

Modified:
13 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

http: add Server.ListenAndServeTLS Fixes issue 1964

Patch Set 1 #

Patch Set 2 : diff -r 894b438b8564 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 894b438b8564 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 209da6914cd6 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -2 lines)			Patch
	M	src/pkg/http/server.go	View	1	3 chunks	+22 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 9 months ago (2011-06-16 20:57:58 UTC) #1

rsc

I don't think this is worth it. Let people define their own servers.

13 years, 9 months ago (2011-06-16 21:47:00 UTC) #2

rsc

Oh, I missed that ListenAndServeTLS is not a current method on Server. Hmm...

13 years, 9 months ago (2011-06-16 21:47:54 UTC) #3

bradfitz

I wavered too, but it's nice for symmetry. Especially as more stuff inevitably goes into ...

13 years, 9 months ago (2011-06-16 21:52:05 UTC) #4

bradfitz

13 years, 9 months ago (2011-06-20 19:19:34 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=37a78ff6db53 ***

http: add Server.ListenAndServeTLS

Fixes issue 1964

R=rsc
CC=golang-dev
http://codereview.appspot.com/4630045

Expand All Messages | Collapse All Messages