Issue 4630042: code review 4630042: doc/effective_go: add a note about prefixing error stri...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4630042: code review 4630042: doc/effective_go: add a note about prefixing error stri... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by nigeltao

Modified:
12 years, 10 months ago

Reviewers:

CC:
r, rsc, golang-dev

Visibility:
Public.

Description

doc/effective_go: add a note about prefixing error strings with their package name.

Patch Set 2 : diff -r e8d5013e1fbb https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e8d5013e1fbb https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r e8d5013e1fbb https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r fc5e8036769a https://go.googlecode.com/hg/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	doc/effective_go.html	View	1 2 3 4	2 chunks	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 10 months ago (2011-06-16 04:14:46 UTC) #1

http://codereview.appspot.com/4630042/diff/4001/doc/effective_go.html File doc/effective_go.html (right): http://codereview.appspot.com/4630042/diff/4001/doc/effective_go.html#newcode2679 doc/effective_go.html:2679: due to an unknown format is "image: unknown format". ...

12 years, 10 months ago (2011-06-16 04:15:43 UTC) #2

nigeltao

PTAL. On 16 June 2011 14:15, <r@golang.org> wrote: > explain why

12 years, 10 months ago (2011-06-16 04:42:28 UTC) #3

LGTM http://codereview.appspot.com/4630042/diff/1002/doc/effective_go.html File doc/effective_go.html (right): http://codereview.appspot.com/4630042/diff/1002/doc/effective_go.html#newcode2678 doc/effective_go.html:2678: to provide additional context. For example, in package ...

12 years, 10 months ago (2011-06-16 05:52:32 UTC) #4

nigeltao

12 years, 10 months ago (2011-06-17 00:51:16 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=12cc5b3cc379 ***

doc/effective_go: add a note about prefixing error strings with their
package name.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/4630042

Expand All Messages | Collapse All Messages