Issue 4628062: debug/elf: Read ELF Program headers.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4628062: debug/elf: Read ELF Program headers.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by mjh

Modified:
1 year, 5 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

debug/elf: Read ELF Program headers. NewFile has been fixed to read ELF Program headers into the structs. Added test coverage.

Patch Set 1 #

Patch Set 2 : diff -r 90f9c658e53d https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -1 line)			Patch
	M	src/pkg/debug/elf/file.go	View	1	5 chunks	+50 lines, -1 line	0 comments	Download
	M	src/pkg/debug/elf/file_test.go	View	1	4 chunks	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mjh

Please review my change: I've added code to read ELF program headers in debug/elf.

13 years, 10 months ago (2011-07-07 07:40:29 UTC) #1

rsc

Looks great. Please complete a CLA as described at http://golang.org/doc/contribute.html#copyright Thanks. Russ

13 years, 9 months ago (2011-07-12 18:49:24 UTC) #3

rsc

13 years, 9 months ago (2011-07-13 19:34:32 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=7b2b77af2001 ***

debug/elf: Read ELF Program headers.

NewFile has been fixed to read ELF Program headers into the structs.
Added test coverage.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4628062

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages