code review 4628045: os: Change Waitmsg.String() to operate on pointer.

os: Change Waitmsg.String() to operate on pointer.

        Fixes issue 1851.

[gmiller, 2011-06-17 13:10:37]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-06-17 13:23:52]

It is hard to believe that this fixes issue 1851.
Won't it still crash inside the String method?

[gmiller, 2011-06-17 13:44:08]

You are correct.  Sorry haven't had my coffee yet this morning.

graham


On Fri, Jun 17, 2011 at 9:23 AM, Russ Cox <rsc@golang.org> wrote:
> It is hard to believe that this fixes issue 1851.
> Won't it still crash inside the String method?
>

[gmiller, 2011-06-17 13:48:36]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-06-17 14:23:55]

Please add a test.

[gmiller, 2011-06-17 14:58:24]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-06-20 19:16:53]

http://codereview.appspot.com/4628045/diff/12001/src/pkg/os/os_test.go
File src/pkg/os/os_test.go (right):

http://codereview.appspot.com/4628045/diff/12001/src/pkg/os/os_test.go#newcod...
src/pkg/os/os_test.go:1048: s := fmt.Sprintf("%v", w)
s := w.String()

http://codereview.appspot.com/4628045/diff/12001/src/pkg/os/os_test.go#newcod...
src/pkg/os/os_test.go:1050: t.Error("String: should be <nil>")
t.Errorf("(*Waitmsg)(nil).String() = %q, want %q", s, "<nil>")

[gmiller, 2011-06-20 19:36:34]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-06-20 19:42:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=96b9097f090a ***

os: change Waitmsg String method to use pointer receiver

Fixes issue 1851.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4628045

Committer: Russ Cox <rsc@golang.org>

[rsc, 2011-06-20 19:42:25]

LGTM