Issue 4627071: code review 4627071: runtime: another attempt to allow stdcall to be used fr...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4627071: code review 4627071: runtime: another attempt to allow stdcall to be used fr... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by brainman

Modified:
13 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev, vcc

Visibility:
Public.

Description

runtime: another attempt to allow stdcall to be used from both 386 and amd64 arch

Patch Set 2 : diff -r 7132c4b0ec21 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7132c4b0ec21 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 18e35543f1af https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -13 lines)			Patch
M	src/pkg/runtime/windows/mem.c	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/windows/os.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/windows/thread.c	View	1	6 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com (cc: rsc@golang.org, vcc.163@gmail.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-06-28 02:36:16 UTC) #1

brainman

Needs http://codereview.appspot.com/4634103/ to work. Alex

13 years, 9 months ago (2011-06-28 02:36:58 UTC) #2

rsc

LGTM http://codereview.appspot.com/4627071/diff/4001/src/pkg/runtime/windows/os.h File src/pkg/runtime/windows/os.h (right): http://codereview.appspot.com/4627071/diff/4001/src/pkg/runtime/windows/os.h#newcode10 src/pkg/runtime/windows/os.h:10: #pragma varargck countpos runtime·stdcall 2 If these aren't ...

13 years, 9 months ago (2011-06-28 02:38:46 UTC) #3

brainman

13 years, 9 months ago (2011-06-28 02:46:26 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=cb5ad47b6e02 ***

runtime: another attempt to allow stdcall to be used from both 386 and amd64
arch

R=rsc
CC=golang-dev, vcc.163
http://codereview.appspot.com/4627071

Expand All Messages | Collapse All Messages