code review 4627051: go/build: include Import objects in Script Inputs

go/build: include Import objects in Script Inputs

This has the effect of making goinstall rebuild a package's
dependencies when they are newer than the current package object.

[adg, 2011-06-21 07:07:38]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-06-21 16:15:26]

This doesn't look correct.  Don't you need to know
which tree each import came from?

[adg, 2011-06-21 22:41:25]

On 22 June 2011 02:15, Russ Cox <rsc@golang.org> wrote:
> This doesn't look correct.  Don't you need to know
> which tree each import came from?

The Import slice is just a list of absolute paths. This new code looks
up the tree for each import and appends the absolute path to Input.
After that point they're just file names.

There will probably be a reason to make Input a richer data structure,
but I don't think this is it.

Andrew

[rsc, 2011-06-22 19:29:38]

LGTM

http://codereview.appspot.com/4627051/diff/1/src/pkg/go/build/build.go
File src/pkg/go/build/build.go (right):

http://codereview.appspot.com/4627051/diff/1/src/pkg/go/build/build.go#newcode40
src/pkg/go/build/build.go:40: t, p, err := FindTree(pkg)
I missed this line on first reading.

[adg, 2011-06-23 00:15:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=e7e745dcb5aa ***

go/build: include Import objects in Script Inputs

This has the effect of making goinstall rebuild a package's
dependencies when they are newer than the current package object.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4627051