code review 4627041: go/build: support building cgo packages on non intel pl...

go/build: support building cgo packages on non intel platforms

See http://codereview.appspot.com/4572045/

[dave_cheney.net, 2011-06-16 01:43:28]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-06-16 01:51:55]

there is no cgo support for arm at all.
it's not just go/build.

[dave_cheney.net, 2011-06-16 01:54:47]

Yup, understood. This CL just makes it possible to use go/build for
cgo at some point in the future by not defaulting to invoking gcc with
-m for all architectures.

On Thu, Jun 16, 2011 at 11:51 AM, Russ Cox <rsc@golang.org> wrote:
> there is no cgo support for arm at all.
> it's not just go/build.
>

[rsc, 2011-06-16 02:10:36]

On Wed, Jun 15, 2011 at 21:54, Dave Cheney <dave@cheney.net> wrote:
> Yup, understood. This CL just makes it possible to use go/build for
> cgo at some point in the future by not defaulting to invoking gcc with
> -m for all architectures.

it also enables TestBuild for cgo/arm, which will fail.

[dave_cheney.net, 2011-06-16 02:14:08]

It doesn't currently fail because you can execute the cgo command successfully.

stora(~/go/src/pkg/go/build) % gotest -v
rm -f _test/go/build.a
5g  -o _gotest_.5 build.go dir.go path.go syslist.go  build_test.go
syslist_test.go
rm -f _test/go/build.a
gopack grc _test/go/build.a _gotest_.5
=== RUN  build.TestBuild
--- PASS: build.TestBuild (1.70 seconds)
=== RUN  build.TestGoodOSArch
--- PASS: build.TestGoodOSArch (0.00 seconds)
PASS

but the resulting _cgo_.o is not linkable.

On Thu, Jun 16, 2011 at 12:10 PM, Russ Cox <rsc@golang.org> wrote:
> On Wed, Jun 15, 2011 at 21:54, Dave Cheney <dave@cheney.net> wrote:
>> Yup, understood. This CL just makes it possible to use go/build for
>> cgo at some point in the future by not defaulting to invoking gcc with
>> -m for all architectures.
>
> it also enables TestBuild for cgo/arm, which will fail.
>

[rsc, 2011-06-16 02:27:24]

LGTM

leaving for adg

[adg, 2011-06-16 03:35:34]

LGTM

[adg, 2011-06-16 03:35:38]

*** Submitted as http://code.google.com/p/go/source/detail?r=ba390b1d5e66 ***

go/build: support building cgo packages on non intel platforms

See http://codereview.appspot.com/4572045/

R=adg, rsc
CC=golang-dev
http://codereview.appspot.com/4627041

Committer: Andrew Gerrand <adg@golang.org>

[dave_cheney.net, 2011-06-16 03:56:59]

Thanks Andrew and Russ.

On Thu, Jun 16, 2011 at 1:35 PM,  <adg@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=ba390b1d5e66 ***
>
> go/build: support building cgo packages on non intel platforms
>
> See http://codereview.appspot.com/4572045/
>
> R=adg, rsc
> CC=golang-dev
> http://codereview.appspot.com/4627041
>
> Committer: Andrew Gerrand <adg@golang.org>
>
>
> http://codereview.appspot.com/4627041/
>