code review 4626067: http: add StripPrefix handler wrapper

http: add StripPrefix handler wrapper

[bradfitz, 2011-06-22 21:02:40]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-06-22 21:13:13]

I spent a while going back and forth on this and
never did anything because I couldn't figure out
a good name.  There are lots of things you could
strip, like query parameters or identifying information
or whatever.

Maybe this should be

// StripPrefix returns a handler that serves HTTP requests
// by removing the given prefix from the request URL's Path
// and invoking the handler h.  StripPrefix handles a
// request for a path that doesn't begin with prefix by
// replying with an HTTP 404 not found error.
func StripPrefix(prefix string, h Handler) Handler

Swapping the arguments makes the order match
the order in which they happen: cut prefix, run h.
It will also be easier to format if you inline a
multiline HandlerFunc there.

In the code, use NotFound and leave RawPath
as is.  The fact that Path begins with prefix does
not imply that RawPath does.  (/%69ndex.html)

Russ

[bradfitz, 2011-06-27 17:59:38]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-06-27 18:02:30]

LGTM

[bradfitz, 2011-06-27 18:03:45]

*** Submitted as http://code.google.com/p/go/source/detail?r=02ee07e29061 ***

http: add StripPrefix handler wrapper

R=rsc
CC=golang-dev
http://codereview.appspot.com/4626067