Issue 4625044: code review 4625044: respect goto restrictions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4625044: code review 4625044: respect goto restrictions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by rsc

Modified:
12 years, 10 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

respect goto restrictions

Patch Set 1 #

Patch Set 2 : diff -r 3a81409b9013 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3a81409b9013 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3a81409b9013 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 12118c2a9829 https://go.googlecode.com/hg/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -94 lines)			Patch
M	src/cmd/hgpatch/main.go	View	1	2 chunks	+5 lines, -9 lines	0 comments	Download
M	src/pkg/crypto/openpgp/packet/signature.go	View	1	3 chunks	+8 lines, -4 lines	0 comments	Download
M	src/pkg/crypto/tls/key_agreement.go	View	1	2 chunks	+7 lines, -8 lines	0 comments	Download
M	src/pkg/debug/dwarf/type.go	View	1	1 chunk	+6 lines, -5 lines	0 comments	Download
M	src/pkg/encoding/pem/pem.go	View	1	3 chunks	+7 lines, -6 lines	0 comments	Download
M	src/pkg/exp/regexp/syntax/parse.go	View	1 2 3	3 chunks	+21 lines, -24 lines	0 comments	Download
M	src/pkg/fmt/scan.go	View	1 2 3	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/pkg/http/url.go	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	src/pkg/net/dnsmsg.go	View	1 2 3	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/net/ipsock.go	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/pkg/net/newpollserver.go	View	1	2 chunks	+8 lines, -6 lines	0 comments	Download
M	src/pkg/patch/textdiff.go	View	1	3 chunks	+7 lines, -3 lines	0 comments	Download
M	src/pkg/strconv/atoi.go	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/pkg/strconv/quote.go	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/pkg/syscall/exec_unix.go	View	1	2 chunks	+9 lines, -7 lines	0 comments	Download
M	test/fixedbugs/bug140.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/fixedbugs/bug178.go	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

LGTM (I haven't analyzed the change in syntax/parse.go). Several files are cleaner now. - gri

12 years, 10 months ago (2011-06-17 01:23:34 UTC) #1

rsc

Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 10 months ago (2011-06-17 10:07:11 UTC) #2

rsc

12 years, 10 months ago (2011-06-17 10:07:18 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=dc6d3cf9279d ***

respect goto restrictions

R=gri
CC=golang-dev
http://codereview.appspot.com/4625044

Expand All Messages | Collapse All Messages