Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(663)

Issue 46160043: code review 46160043: net: work around Solaris connect issue when server clos... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by iant
Modified:
10 years, 3 months ago
Reviewers:
dfc, bradfitz
CC:
golang-codereviews, bradfitz, dfc
Visibility:
Public.

Description

net: work around Solaris connect issue when server closes socket On Solaris, if you do a in-progress connect, and then the server accepts and closes the socket, the client's later attempt to complete the connect will fail with EINVAL. Handle this case by assuming that the connect succeeded. This code is weird enough that it is implemented as Solaris-only so that it doesn't hide a real error on a different OS. Update issue 6828

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 0d4f83bb938b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/pkg/net/fd_unix.go View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5
iant
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 3 months ago (2013-12-28 05:57:58 UTC) #1
bradfitz
LGTM On Dec 27, 2013 9:58 PM, <iant@golang.org> wrote: > Reviewers: golang-codereviews, > > Message: ...
10 years, 3 months ago (2013-12-28 06:00:36 UTC) #2
dfc
https://codereview.appspot.com/46160043/diff/1/src/pkg/net/fd_unix.go File src/pkg/net/fd_unix.go (right): https://codereview.appspot.com/46160043/diff/1/src/pkg/net/fd_unix.go#newcode89 src/pkg/net/fd_unix.go:89: if runtime.GOOS == "solaris" && err == syscall.EINVAL { ...
10 years, 3 months ago (2013-12-28 06:02:12 UTC) #3
iant
On 2013/12/28 06:02:12, dfc wrote: > > https://codereview.appspot.com/46160043/diff/1/src/pkg/net/fd_unix.go#newcode89 > src/pkg/net/fd_unix.go:89: if runtime.GOOS == "solaris" && ...
10 years, 3 months ago (2013-12-28 17:36:53 UTC) #4
iant
10 years, 3 months ago (2013-12-28 17:38:09 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=3ae7a530dd4e ***

net: work around Solaris connect issue when server closes socket

On Solaris, if you do a in-progress connect, and then the
server accepts and closes the socket, the client's later
attempt to complete the connect will fail with EINVAL.  Handle
this case by assuming that the connect succeeded.  This code
is weird enough that it is implemented as Solaris-only so that
it doesn't hide a real error on a different OS.

Update issue 6828

R=golang-codereviews, bradfitz, dave
CC=golang-codereviews
https://codereview.appspot.com/46160043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b