Issue 4611041: code review 4611041: gc: handle go print() and go println()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4611041: code review 4611041: gc: handle go print() and go println() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by stephenm

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

gc: handle go print() and go println() Fixes issue 1952.

Patch Set 1 #

Patch Set 2 : diff -r d78ff92cd160 https://go.googlecode.com/hg #

Patch Set 3 : diff -r d78ff92cd160 https://go.googlecode.com/hg #

Patch Set 4 : diff -r d78ff92cd160 https://go.googlecode.com/hg #

Patch Set 5 : diff -r d78ff92cd160 https://go.googlecode.com/hg #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
M	src/cmd/gc/walk.c	View	1	1 chunk	+10 lines, -1 line	0 comments	Download
M	test/golden.out	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A	test/goprint.go	View	1 2 3	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

stephenm

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 9 months ago (2011-06-13 08:59:47 UTC) #1

rsc

cd $GOROOT hg add test/goprint.go hg file 4611041 test/goprint.go

13 years, 9 months ago (2011-06-13 12:03:31 UTC) #3

stephenm

> cd $GOROOT > hg add test/goprint.go > hg file 4611041 test/goprint.go Yeah, I missed ...

13 years, 9 months ago (2011-06-13 12:08:31 UTC) #4

stephenm

13 years, 9 months ago (2011-06-13 12:51:03 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=881a0fc6528d ***

gc: handle go print() and go println()

Fixes issue 1952.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4611041

Expand All Messages | Collapse All Messages