code review 4602063: mime/multipart: convert Reader from interface to struct

mime/multipart: convert Reader from interface to struct

It was always a weird interface but I didn't know what I
was doing at the time.  rsc questioned me about it then
but didn't press on it during review.  Then adg bugged me
about it too recently.

So clean it up. It parallels the Writer struct too.

[bradfitz, 2011-06-14 23:18:04]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-06-14 23:59:43]

http://codereview.appspot.com/4602063/diff/3005/src/pkg/mime/multipart/multip...
File src/pkg/mime/multipart/multipart.go (right):

http://codereview.appspot.com/4602063/diff/3005/src/pkg/mime/multipart/multip...
src/pkg/mime/multipart/multipart.go:177: type Reader struct {
it feels slightly off to have a thing called Reader that doesn't implement Read.
perhaps not fatal but is there another name you could use?

[bradfitz, 2011-06-15 00:13:35]

On Tue, Jun 14, 2011 at 4:59 PM, <r@golang.org> wrote:

>
> http://codereview.appspot.com/**4602063/diff/3005/src/pkg/**
>
mime/multipart/multipart.go<http://codereview.appspot.com/4602063/diff/3005/src/pkg/mime/multipart/multipart.go>
> File src/pkg/mime/multipart/**multipart.go (right):
>
> http://codereview.appspot.com/**4602063/diff/3005/src/pkg/**
>
mime/multipart/multipart.go#**newcode177<http://codereview.appspot.com/4602063/diff/3005/src/pkg/mime/multipart/multipart.go#newcode177>
> src/pkg/mime/multipart/**multipart.go:177: type Reader struct {
> it feels slightly off to have a thing called Reader that doesn't
> implement Read. perhaps not fatal but is there another name you could
> use?
>

I'd rather just abandon this CL than rename anything.  That means we'd also
have to rename NewReader and start breaking people's code over something
that's in some ways (de-interfacing) a step backwards.

Looking at the full package+type it's multipart.Reader.  io.ByteReader
doesn't implement Read but has Read in its name.  multipart.MultipartReader
is stuttery.

*shrug*

[r, 2011-06-15 00:14:26]

i was just asking.

LGTM

[rsc, 2011-06-15 00:55:51]

LGTM

[bradfitz, 2011-06-16 15:56:03]

*** Submitted as http://code.google.com/p/go/source/detail?r=76cd8f767f5e ***

mime/multipart: convert Reader from interface to struct

It was always a weird interface but I didn't know what I
was doing at the time.  rsc questioned me about it then
but didn't press on it during review.  Then adg bugged me
about it too recently.

So clean it up. It parallels the Writer struct too.

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/4602063