Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(340)

Issue 4601058: code review 4601058: syscall: mksyscall_windows.pl should output unix newline. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by mattn
Modified:
13 years, 9 months ago
Reviewers:
CC:
golang-dev_googlecode.com, bradfitz, brainman, golang-dev
Visibility:
Public.

Description

syscall: mksyscall_windows.pl should output unix newline.

Patch Set 1 #

Patch Set 2 : diff -r d86f80185297 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d86f80185297 http://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d86f80185297 http://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/pkg/syscall/mksyscall_windows.pl View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
mattn
Hello golang-dev@googlecode.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg/
13 years, 9 months ago (2011-06-15 00:41:02 UTC) #1
bradfitz
LGTM On Tue, Jun 14, 2011 at 5:41 PM, <mattn.jp@gmail.com> wrote: > Reviewers: golang-dev_googlecode.com, > ...
13 years, 9 months ago (2011-06-15 00:42:29 UTC) #2
brainman
LGTM
13 years, 9 months ago (2011-06-15 01:50:10 UTC) #3
brainman
13 years, 9 months ago (2011-06-15 01:50:33 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=6bf5e0a7d60a ***

syscall: mksyscall_windows.pl should output unix newline.

R=golang-dev, bradfitz, alex.brainman
CC=golang-dev
http://codereview.appspot.com/4601058

Committer: Alex Brainman <alex.brainman@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b