Issue 4601051: code review 4601051: gopack: make unused page() function a fatal error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4601051: code review 4601051: gopack: make unused page() function a fatal error (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by dave

Modified:
12 years, 11 months ago

Reviewers:

CC:
iant, rsc, golang-dev

Visibility:
Public.

Description

gopack: make unused page() function a fatal error

Patch Set 1 #

Patch Set 2 : diff -r b2d04a287628 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b2d04a287628 https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -18 lines)			Patch
	M	src/cmd/gopack/ar.c	View	1	1 chunk	+1 line, -18 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello iant@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2011-06-10 01:08:58 UTC) #1

rsc

On Thu, Jun 9, 2011 at 21:15, Dave Cheney <dave@cheney.net> wrote: > If you happy ...

12 years, 11 months ago (2011-06-10 02:10:39 UTC) #2

rsc

never mind; i will submit this as is to fix the windows build

12 years, 11 months ago (2011-06-10 02:38:29 UTC) #3

rsc

12 years, 11 months ago (2011-06-10 02:41:24 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=894d70dafa01 ***

gopack: make unused page function a fatal error

R=iant, rsc
CC=golang-dev
http://codereview.appspot.com/4601051

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages