Issue 460042: code review 460042: godoc: fix formatting of -src output

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 460042: code review 460042: godoc: fix formatting of -src output (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by gri

Modified:
15 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

godoc: fix formatting of -src output - go/filter.go: make MergePackageFiles smarter - go/printer.go: handle positions from multiple files

Patch Set 1 #

Patch Set 2 : code review 460042: godoc: fix formatting of -src output #

Patch Set 3 : code review 460042: godoc: fix formatting of -src output #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -13 lines)			Patch
M	src/cmd/godoc/godoc.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/ast/filter.go	View		4 chunks	+99 lines, -9 lines	0 comments	Download
M	src/pkg/go/printer/printer.go	View	1	4 chunks	+23 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-12 00:37:24 UTC) #1

gri

15 years ago (2010-03-12 00:44:59 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e8f590675c79 ***

godoc: fix formatting of -src output
- go/filter.go: make MergePackageFiles smarter
- go/printer.go: handle positions from multiple files

R=rsc
CC=golang-dev
http://codereview.appspot.com/460042

Expand All Messages | Collapse All Messages