Issue 4589045: code review 4589045: image: add Paletted.Set, and a basic test of the concre...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4589045: code review 4589045: image: add Paletted.Set, and a basic test of the concre... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by nigeltao

Modified:
12 years, 10 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

image: add Paletted.Set, and a basic test of the concrete image types.

Patch Set 2 : diff -r 52f9c61fd8d8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 52f9c61fd8d8 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 52f9c61fd8d8 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r f5bb473f1306 https://go.googlecode.com/hg/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -6 lines)			Patch
	M	src/pkg/image/image.go	View	1 2 3	3 chunks	+17 lines, -6 lines	0 comments	Download
	A	src/pkg/image/image_test.go	View	1	1 chunk	+71 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 10 months ago (2011-06-09 05:40:20 UTC) #1

http://codereview.appspot.com/4589045/diff/4001/src/pkg/image/image.go File src/pkg/image/image.go (right): http://codereview.appspot.com/4589045/diff/4001/src/pkg/image/image.go#newcode571 src/pkg/image/image.go:571: func (p PalettedColorModel) ConvertIndex(c Color) int { weird name. ...

12 years, 10 months ago (2011-06-09 06:03:55 UTC) #2

nigeltao

12 years, 10 months ago (2011-06-10 04:07:36 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=bc0e6f3c2574 ***

image: add Paletted.Set, and a basic test of the concrete image types.

R=r
CC=golang-dev
http://codereview.appspot.com/4589045

Expand All Messages | Collapse All Messages