code review 4584060: go/build: remove crud in cgotest/_obj

go/build: remove crud in cgotest/_obj

[dave_cheney.net, 2011-06-15 06:08:25]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-06-15 06:21:10]

LGTM

On 15 June 2011 16:08,  <dave@cheney.net> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> go/build: remove crud in cgotest/_obj
>
> Please review this at http://codereview.appspot.com/4584060/
>
> Affected files:
>  M src/pkg/go/build/Makefile
>
>
> Index: src/pkg/go/build/Makefile
> ===================================================================
> --- a/src/pkg/go/build/Makefile
> +++ b/src/pkg/go/build/Makefile
> @@ -11,7 +11,7 @@
>        path.go\
>        syslist.go\
>
> -CLEANFILES+=syslist.go
> +CLEANFILES+=syslist.go cgotest/_obj
>
>  include ../../../Make.pkg
>
>
>
>

[adg, 2011-06-15 06:39:26]

*** Submitted as http://code.google.com/p/go/source/detail?r=78a6b3731880 ***

go/build: remove crud in cgotest/_obj

R=adg
CC=golang-dev
http://codereview.appspot.com/4584060

Committer: Andrew Gerrand <adg@golang.org>

[rsc, 2011-06-15 13:05:36]

That should be a last resort.
The test should clean up after itself.

[adg, 2011-06-15 22:58:14]

On 15 June 2011 23:05, Russ Cox <rsc@golang.org> wrote:
> That should be a last resort.
> The test should clean up after itself.

It does, but the test also checks that it has cleaned everything
completely. Dave had a situation where a previous test with GOARCH=386
had left some .8 files around that weren't being cleaned when
GOARCH=amd64. The test then couldn't remove _obj and failed.

[dave_cheney.net, 2011-06-15 23:25:48]

There were also other cases where building on a single arch would cause the test
to fail, but your point is taken, this was a crude solution. I'll have another
bash today, probably resulting in an rmdir of cgotest/_obj before starting the
test. 

Cheers

Dave


Sent from my C64

On 16/06/2011, at 8:57, Andrew Gerrand <adg@golang.org> wrote:

> On 15 June 2011 23:05, Russ Cox <rsc@golang.org> wrote:
>> That should be a last resort.
>> The test should clean up after itself.
> 
> It does, but the test also checks that it has cleaned everything
> completely. Dave had a situation where a previous test with GOARCH=386
> had left some .8 files around that weren't being cleaned when
> GOARCH=amd64. The test then couldn't remove _obj and failed.