code review 4572049: go/scanner: partially revert CL4538096 now that we have...

go/scanner: partially revert CL4538096 now that we have %#U for runes

[gri, 2011-06-08 20:32:52]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-06-08 20:37:45]

LGTM

http://codereview.appspot.com/4572049/diff/1/src/pkg/go/scanner/scanner.go
File src/pkg/go/scanner/scanner.go (right):

http://codereview.appspot.com/4572049/diff/1/src/pkg/go/scanner/scanner.go#ne...
src/pkg/go/scanner/scanner.go:678: S.error(offs, fmt.Sprintf("illegal character
%q (%U)", ch, ch))
weird but harmless I guess to see "illegal character U+XXXX (U+XXXX)"

[rsc, 2011-06-08 20:47:27]

i commented on 4538096 that

---
This has come up a bunch of times in various programs.
Maybe there should be an alternate quote format
(%#U?) that prints «'x' U+0078» when x is printable
and just the usual %U «U+000A» when not.
---

that triggered the recent addition of unicode.IsPrint.
now that it's there, maybe we should add %#U?

[gri, 2011-06-08 20:50:52]

[reply to all this time]

yes. waiting for Rob to comment on this before submitting since he
commented on it last time as well.

or perhaps it should be %#q ?

- gri

On Wed, Jun 8, 2011 at 1:47 PM, Russ Cox <rsc@golang.org> wrote:
> i commented on 4538096 that
>
> ---
> This has come up a bunch of times in various programs.
> Maybe there should be an alternate quote format
> (%#U?) that prints «'x' U+0078» when x is printable
> and just the usual %U «U+000A» when not.
> ---
>
> that triggered the recent addition of unicode.IsPrint.
> now that it's there, maybe we should add %#U?
>

[rsc, 2011-06-08 20:58:58]

%#q is taken.  %#U makes sense since
the thing it does always is the U+1234 format.

On Wed, Jun 8, 2011 at 16:50, Robert Griesemer <gri@golang.org> wrote:
> [reply to all this time]
>
> yes. waiting for Rob to comment on this before submitting since he
> commented on it last time as well.
>
> or perhaps it should be %#q ?
>
> - gri
>
> On Wed, Jun 8, 2011 at 1:47 PM, Russ Cox <rsc@golang.org> wrote:
>> i commented on 4538096 that
>>
>> ---
>> This has come up a bunch of times in various programs.
>> Maybe there should be an alternate quote format
>> (%#U?) that prints «'x' U+0078» when x is printable
>> and just the usual %U «U+000A» when not.
>> ---
>>
>> that triggered the recent addition of unicode.IsPrint.
>> now that it's there, maybe we should add %#U?
>>
>

[r, 2011-06-08 21:46:22]

%#U will be my reward once I'm finished updating the course notes.

-rob

[gri, 2011-06-11 00:15:26]

Hello r@golang.org, bradfitz@golang.org, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2011-06-11 00:16:40]

LGTM

[gri, 2011-06-11 00:19:04]

*** Submitted as http://code.google.com/p/go/source/detail?r=2d397251a4f4 ***

go/scanner: partially revert CL4538096 now that we have %#U for runes

R=r, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/4572049