code review 4572045: go/build: support building cgo packages on non intel pl...

go/build: support building cgo packages on non intel platforms

[dave_cheney.net, 2011-06-07 05:54:35]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-06-07 06:06:28]

http://codereview.appspot.com/4572045/diff/4001/src/pkg/go/build/build.go
File src/pkg/go/build/build.go (right):

http://codereview.appspot.com/4572045/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:211: gccargs := []string{"gcc"}
a := []string{"gcc", "-I", ".", "-g", "-fPIC", "-O2"}

http://codereview.appspot.com/4572045/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:214: gccargs = append(gccargs, "-m32")
a = append(a, "-m32")
and ditto for 6

http://codereview.appspot.com/4572045/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:218: // TODO(dfc) handle GOARM
// TODO(dfc): handle GOARM

(note the colon)

http://codereview.appspot.com/4572045/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:220: gccargs = append(gccargs, "-I", ".", "-g",
"-fPIC", "-O2")
drop this

http://codereview.appspot.com/4572045/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:221: return append(gccargs, args...)
return append(a, args...)

[dave_cheney.net, 2011-06-07 06:28:24]

Thanks for your feedback. PTAL.

http://codereview.appspot.com/4572045/diff/4001/src/pkg/go/build/build.go
File src/pkg/go/build/build.go (right):

http://codereview.appspot.com/4572045/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:211: gccargs := []string{"gcc"}
On 2011/06/07 06:06:28, adg wrote:
> a := []string{"gcc", "-I", ".", "-g", "-fPIC", "-O2"}

Done.

http://codereview.appspot.com/4572045/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:214: gccargs = append(gccargs, "-m32")
On 2011/06/07 06:06:28, adg wrote:
> a = append(a, "-m32")
> and ditto for 6

Done.

http://codereview.appspot.com/4572045/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:218: // TODO(dfc) handle GOARM
removed

http://codereview.appspot.com/4572045/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:220: gccargs = append(gccargs, "-I", ".", "-g",
"-fPIC", "-O2")
On 2011/06/07 06:06:28, adg wrote:
> drop this

Done.

http://codereview.appspot.com/4572045/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:221: return append(gccargs, args...)
On 2011/06/07 06:06:28, adg wrote:
> return append(a, args...)

Done.

[adg, 2011-06-07 06:44:00]

LGTM

[adg, 2011-06-07 06:45:03]

On 2011/06/07 06:44:00, adg wrote:
> LGTM

I'll submit this once my other changes go through.

[dave_cheney.net, 2011-06-16 01:13:30]

<nudge />

[adg, 2011-06-16 01:25:12]

On 2011/06/16 01:13:30, dfc wrote:
> <nudge />

sync and run 'hg upload 4572045' again.

[dave_cheney.net, 2011-06-16 01:26:35]

*** Abandoned ***

[dave_cheney.net, 2011-06-16 01:26:57]

On 2011/06/16 01:26:35, dfc wrote:
> *** Abandoned ***

Lost the changeset on the local machine. I'll submit another CL

[dave_cheney.net, 2011-06-18 09:52:39]

*** Abandoned ***