Issue 4571071: code review 4571071: gc: frame compaction for arm.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4571071: code review 4571071: gc: frame compaction for arm. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by lvd

Modified:
13 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gc: frame compaction for arm. Required moving some parts of gc/pgen.c to ?g/ggen.c on linux tests pass for all 3 architectures, and frames are actually compacted (diagnostic code for that has been removed from the CL).

Patch Set 1 #

Patch Set 2 : diff -r a1af950dcb9c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a1af950dcb9c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a1af950dcb9c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4dd9d1a59ff9 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -22 lines)			Patch
M	src/cmd/5g/ggen.c	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
M	src/cmd/6g/ggen.c	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
M	src/cmd/8g/ggen.c	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1	3 chunks	+3 lines, -1 line	0 comments	Download
M	src/cmd/gc/pgen.c	View	1	5 chunks	+5 lines, -21 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

lvd

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-06-14 14:39:11 UTC) #1

lvd

13 years, 9 months ago (2011-06-14 15:03:40 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=313b509c1a53 ***

gc: frame compaction for arm.

Required moving some parts of gc/pgen.c to ?g/ggen.c

on linux tests pass for all 3 architectures, and
frames are actually compacted (diagnostic code for
that has been removed from the CL).

R=rsc
CC=golang-dev
http://codereview.appspot.com/4571071

Expand All Messages | Collapse All Messages