Issue 4568078: code review 4568078: debug/elf: rename test .o files to .obj

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4568078: code review 4568078: debug/elf: rename test .o files to .obj (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by niemeyer

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

debug/elf: rename test .o files to .obj .o files are commonly found in default ignore lists by source management tools, including dpkg-source, bzr, etc.

Patch Set 1 #

Patch Set 2 : code review 4568078: debug/elf: rename test .o files to .obj #

Patch Set 3 : diff -r a1af950dcb9c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a1af950dcb9c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 0648704168fb https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
M	src/pkg/debug/elf/file_test.go	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/debug/elf/testdata/go-relocation-test-gcc424-x86-64.obj	View	1 2	Binary file		0 comments	Download
M	src/pkg/debug/elf/testdata/go-relocation-test-gcc441-x86.obj	View	1 2	Binary file		0 comments	Download
M	src/pkg/debug/elf/testdata/go-relocation-test-gcc441-x86-64.obj	View	1 2	Binary file		0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-06-14 14:29:54 UTC) #1

niemeyer

13 years, 8 months ago (2011-06-14 18:06:48 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=db55aab08087 ***

debug/elf: rename test .o files to .obj

.o files are commonly found in default ignore lists by
source management tools, including dpkg-source, bzr, etc.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4568078

Expand All Messages | Collapse All Messages