code review 45640043: go.net/ipv6: simplfy control message marshaling

go.net/ipv6: simplfy control message marshaling

[mikio, 2013-12-26 08:17:34]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.net

[mikio, 2013-12-31 08:21:49]

ping

[dave_cheney.net, 2013-12-31 10:21:00]

LGTM with one comment.

https://codereview.appspot.com/45640043/diff/80001/ipv6/control_rfc2292_unix.go
File ipv6/control_rfc2292_unix.go (right):

https://codereview.appspot.com/45640043/diff/80001/ipv6/control_rfc2292_unix....
ipv6/control_rfc2292_unix.go:146: setSockaddr(sa, cm.NextHop, cm.IfIndex)
setSockaddr doesn't set sa.Len, is this an issue ?

[mikio, 2013-12-31 14:20:11]

On 2013/12/31 10:21:00, dfc wrote:

>
https://codereview.appspot.com/45640043/diff/80001/ipv6/control_rfc2292_unix....
> ipv6/control_rfc2292_unix.go:146: setSockaddr(sa, cm.NextHop, cm.IfIndex)
> setSockaddr doesn't set sa.Len, is this an issue ?

I don't understand. setSockaddr in sys_darwin.go sets Len of
syscall.RawSockaddrInet6.

[mikio, 2013-12-31 14:20:58]

*** Submitted as
https://code.google.com/p/go/source/detail?r=45528560020f&repo=net ***

go.net/ipv6: simplfy control message marshaling

R=golang-codereviews, dave
CC=golang-codereviews
https://codereview.appspot.com/45640043

[dave_cheney.net, 2013-12-31 14:22:02]

It doesn't on Linux



> On 1 Jan 2014, at 1:20, mikioh.mikioh@gmail.com wrote:
> 
> On 2013/12/31 10:21:00, dfc wrote:
> 
> 
>
https://codereview.appspot.com/45640043/diff/80001/ipv6/control_rfc2292_unix....
>> ipv6/control_rfc2292_unix.go:146: setSockaddr(sa, cm.NextHop,
> cm.IfIndex)
>> setSockaddr doesn't set sa.Len, is this an issue ?
> 
> I don't understand. setSockaddr in sys_darwin.go sets Len of
> syscall.RawSockaddrInet6.
> 
> https://codereview.appspot.com/45640043/

[mikio, 2013-12-31 14:24:10]

On Tue, Dec 31, 2013 at 11:21 PM, Dave Cheney <dave@cheney.net> wrote:

> It doesn't on Linux

Did you have a look at sockaddr_in6 or RawSockaddrInet6 of Linux?

[dave_cheney.net, 2013-12-31 14:26:46]

I looked wherever setSockaddr is defined, I may have looked in the wrong place.




> On 1 Jan 2014, at 1:24, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
> 
>> On Tue, Dec 31, 2013 at 11:21 PM, Dave Cheney <dave@cheney.net> wrote:
>> 
>> It doesn't on Linux
> 
> Did you have a look at sockaddr_in6 or RawSockaddrInet6 of Linux?