Issue 45620043: code review 45620043: go.net/ipv6: add missing API tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 45620043: code review 45620043: go.net/ipv6: add missing API tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by mikio

Modified:
11 years, 2 months ago

Reviewers:
dave

CC:
golang-codereviews, dave_cheney.net

Visibility:
Public.

Description

go.net/ipv6: add missing API tests Now the package has a code coverage of 76.1% of statements. Also fixes flaky concurrent test. Fixes issue 5696.

Patch Set 1 : diff -r 127da548775d https://code.google.com/p/go.net #

Total comments: 6

Patch Set 2 : diff -r e0d7bfced6e2 https://code.google.com/p/go.net #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+233 lines, -138 lines)			Patch
R	ipv6/control_test.go	View		1 chunk	+0 lines, -42 lines	0 comments	Download
M	ipv6/icmp_test.go	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	ipv6/multicast_test.go	View	1	5 chunks	+19 lines, -9 lines	0 comments	Download
A	ipv6/readwrite_test.go	View	1	1 chunk	+168 lines, -0 lines	0 comments	Download
M	ipv6/unicast_test.go	View		7 chunks	+28 lines, -87 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

11 years, 2 months ago (2013-12-26 08:17:12 UTC) #1

dave_cheney.net

LGTM with minor comments. https://codereview.appspot.com/45620043/diff/220001/ipv6/multicast_test.go File ipv6/multicast_test.go (right): https://codereview.appspot.com/45620043/diff/220001/ipv6/multicast_test.go#newcode39 ipv6/multicast_test.go:39: defer p.Close() Why did you ...

11 years, 2 months ago (2013-12-31 10:33:22 UTC) #3

mikio

11 years, 2 months ago (2013-12-31 14:25:03 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=7aeb0fe2819e&repo=net ***

go.net/ipv6: add missing API tests

Now the package has a code coverage of 76.1% of statements.
Also fixes flaky concurrent test.

Fixes issue 5696.

R=golang-codereviews, dave
CC=golang-codereviews
https://codereview.appspot.com/45620043

https://codereview.appspot.com/45620043/diff/220001/ipv6/multicast_test.go
File ipv6/multicast_test.go (right):

https://codereview.appspot.com/45620043/diff/220001/ipv6/multicast_test.go#ne...
ipv6/multicast_test.go:39: defer p.Close()
On 2013/12/31 10:33:22, dfc wrote:
> Why did you move this code ?

nothing, will revert.

https://codereview.appspot.com/45620043/diff/220001/ipv6/multicast_test.go#ne...
ipv6/multicast_test.go:120: defer p.Close()
On 2013/12/31 10:33:22, dfc wrote:
> same

ditto

https://codereview.appspot.com/45620043/diff/220001/ipv6/readwrite_test.go
File ipv6/readwrite_test.go (right):

https://codereview.appspot.com/45620043/diff/220001/ipv6/readwrite_test.go#ne...
ipv6/readwrite_test.go:44: if _, err := c.WriteTo(wb, dst); err != nil {
On 2013/12/31 10:33:22, dfc wrote:
> Is it necessary to check for short writes ?

Done.

Expand All Messages | Collapse All Messages