Issue 4553061: code review 4553061: encoding/line: delete package.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4553061: code review 4553061: encoding/line: delete package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by r

Modified:
13 years, 10 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

encoding/line: delete package. Its functionality is now in bufio. Fixes issue 1869.

Patch Set 1 #

Patch Set 2 : diff -r cd8780efaa1e https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -260 lines)			Patch
M	src/pkg/Makefile	View	1 chunk	+0 lines, -1 line	0 comments	Download
R	src/pkg/encoding/line/Makefile	View	1 chunk	+0 lines, -11 lines	0 comments	Download
R	src/pkg/encoding/line/line.go	View	1 chunk	+0 lines, -115 lines	0 comments	Download
R	src/pkg/encoding/line/line_test.go	View	1 chunk	+0 lines, -133 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-05-24 05:59:46 UTC) #1

13 years, 10 months ago (2011-05-24 06:05:31 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=26a2b651a7a9 ***

encoding/line: delete package.
Its functionality is now in bufio.
Fixes issue 1869.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/4553061

Expand All Messages | Collapse All Messages