Issue 4552062: code review 4552062: http: Client test for streaming responses (no code changes)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4552062: code review 4552062: http: Client test for streaming responses (no code changes) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by bradfitz

Modified:
13 years, 10 months ago

Reviewers:

CC:
golang-dev, rsc1

Visibility:
Public.

Description

http: Client test for streaming responses (no code changes) I had a report that this was broken. It seems fine. I think the reporter was just never flushing their response headers. If I omit the test server's initial Flush I get the same behavior as reported. (a hang at Client.Get)

Patch Set 1 #

Patch Set 2 : diff -r 97c05fcd5d30 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 97c05fcd5d30 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 97c05fcd5d30 https://go.googlecode.com/hg #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -0 lines)			Patch
	M	src/pkg/http/client_test.go	View	1	2 chunks	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 10 months ago (2011-05-24 15:55:34 UTC) #1

bradfitz

13 years, 10 months ago (2011-05-24 16:02:06 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e3d817fd7010 ***

http: Client test for streaming responses (no code changes)

I had a report that this was broken. It seems fine.

I think the reporter was just never flushing their response
headers.  If I omit the test server's initial Flush I get the
same behavior as reported. (a hang at Client.Get)

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4552062

Expand All Messages | Collapse All Messages