Issue 4550118: code review 4550118: go/build: exclude cgo test from arm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4550118: code review 4550118: go/build: exclude cgo test from arm (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by adg

Modified:
13 years, 10 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

go/build: exclude cgo test from arm go/build: include command output in error values go/build: add syslist.go to .hgignore

Patch Set 2 : diff -r 8254f8746317 https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
M	.hgignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/go/build/build.go	View		3 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/go/build/build_test.go	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-06-05 23:17:34 UTC) #1

LGTM http://codereview.appspot.com/4550118/diff/1/src/pkg/go/build/build_test.go File src/pkg/go/build/build_test.go (right): http://codereview.appspot.com/4550118/diff/1/src/pkg/go/build/build_test.go#newcode28 src/pkg/go/build/build_test.go:28: if runtime.GOARCH == "arm" && strings.Contains(d, "cgo") { ...

13 years, 10 months ago (2011-06-05 23:22:18 UTC) #2

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=a3861d7d08a9 *** go/build: exclude cgo test from arm go/build: include command output ...

13 years, 10 months ago (2011-06-05 23:25:37 UTC) #3

adg

13 years, 10 months ago (2011-06-05 23:25:45 UTC) #4

On 6 June 2011 09:22,  <r@golang.org> wrote:
>
http://codereview.appspot.com/4550118/diff/1/src/pkg/go/build/build_test.go#n...
> src/pkg/go/build/build_test.go:28: if runtime.GOARCH == "arm" &&
> strings.Contains(d, "cgo") {
> maybe /cgo?

Good call.

Expand All Messages | Collapse All Messages