code review 4550084: cgo: support pkg-config for flags and libs

cgo: support pkg-config for flags and libs

Fixes issue #1853.

[niemeyer, 2011-05-26 01:41:16]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mattn, 2011-05-26 02:02:24]

Thanks you for writing CL.
(Sorry about my jumping the gun)

http://codereview.appspot.com/4550084/diff/5001/src/cmd/cgo/gcc.go
File src/cmd/cgo/gcc.go (right):

http://codereview.appspot.com/4550084/diff/5001/src/cmd/cgo/gcc.go#newcode113
src/cmd/cgo/gcc.go:113: cflags, ldflags, err = pkgConfig(v)
Why not support multiple packages?

#cgo pkg-config: cairo glib-2.0

http://codereview.appspot.com/4550084/diff/5001/src/cmd/cgo/gcc.go#newcode163
src/cmd/cgo/gcc.go:163: if !ok {
irrespective of ok, I guess better to show warnings on above line. this will be
helpful for debug.

http://codereview.appspot.com/4550084/diff/5001/src/cmd/cgo/gcc.go#newcode170
src/cmd/cgo/gcc.go:170: if !ok {
same above.

http://codereview.appspot.com/4550084/diff/5001/src/cmd/cgo/gcc.go#newcode246
src/cmd/cgo/gcc.go:246: for i := 0; i < len(s); i++ {
strings.IndexAny?

[niemeyer, 2011-05-26 11:53:09]

> (Sorry about my jumping the gun)

No worries.

> Why not support multiple packages?

Indeed, that's a good idea. Thanks.

> irrespective of ok, I guess better to show warnings on above line. 

It will have no context.  If the command didn't fail
we don't really care about it.

> strings.IndexAny?

The logic there is correct, and is not the same as IndexAny.

[niemeyer, 2011-05-26 11:53:39]

Hello golang-dev@googlegroups.com, mattn.jp@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[mattn, 2011-05-26 13:07:13]

LGTM

On 2011/05/26 11:53:39, niemeyer wrote:
> Hello mailto:golang-dev@googlegroups.com, mailto:mattn.jp@gmail.com (cc:
> mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

[adg, 2011-05-26 22:43:02]

LGTM

http://codereview.appspot.com/4550084/diff/14001/src/cmd/cgo/doc.go
File src/cmd/cgo/doc.go (right):

http://codereview.appspot.com/4550084/diff/14001/src/cmd/cgo/doc.go#newcode39
src/cmd/cgo/doc.go:39: tool using a #cgo directive with the package names:
tool using a '#cgo pkg-config:' directive followed by the package names.
For example:

[niemeyer, 2011-05-27 01:18:54]

> For example:

Done. Thanks Andrew.

[niemeyer, 2011-05-27 01:19:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=01b6a240e0b7 ***

cgo: support pkg-config for flags and libs

Fixes issue #1853.

R=golang-dev, mattn.jp, adg
CC=golang-dev
http://codereview.appspot.com/4550084

[rsc1, 2011-05-27 03:20:25]

Nice