Issue 4550075: code review 4550075: docs: remove some prose-unworthy empty parentheses.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4550075: code review 4550075: docs: remove some prose-unworthy empty parentheses. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by r

Modified:
13 years, 10 months ago

Reviewers:

CC:
gri, rsc, golang-dev

Visibility:
Public.

Description

docs: remove some prose-unworthy empty parentheses. In our evolving style, prose should name a function "f" not "f()".

Patch Set 2 : diff -r b3d402747afa https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r b3d402747afa https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -55 lines)			Patch
M	doc/effective_go.html	View		9 chunks	+19 lines, -17 lines	0 comments	Download
M	doc/go_spec.html	View	1	5 chunks	+6 lines, -6 lines	0 comments	Download
M	doc/go_tutorial.html	View	1 2	13 chunks	+16 lines, -16 lines	0 comments	Download
M	doc/go_tutorial.txt	View	1 2	11 chunks	+16 lines, -16 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-05-24 20:28:09 UTC) #1

gri

FYI http://codereview.appspot.com/4550075/diff/1/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/4550075/diff/1/doc/go_spec.html#newcode824 doc/go_spec.html:824: The <code>make</code> call allocates a new, hidden array ...

13 years, 10 months ago (2011-05-24 20:31:40 UTC) #2

Hello golang-dev@googlegroups.com, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 10 months ago (2011-05-24 20:36:36 UTC) #3

gri

LGTM http://codereview.appspot.com/4550075/diff/5001/doc/go_tutorial.html File doc/go_tutorial.html (right): http://codereview.appspot.com/4550075/diff/5001/doc/go_tutorial.html#newcode770 doc/go_tutorial.html:770: <code>nr</code> and <code>er</code> to hold the return values ...

13 years, 10 months ago (2011-05-24 20:42:23 UTC) #5

13 years, 10 months ago (2011-05-24 20:44:14 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=2590caf6aaaa ***

docs: remove some prose-unworthy empty parentheses.
In our evolving style, prose should name a function "f" not "f()".

R=gri, rsc
CC=golang-dev
http://codereview.appspot.com/4550075

Expand All Messages | Collapse All Messages