code review 4550062: net: re-enable wildcard listening

net: re-enable wildcard listening

Fixes issue 1854.

[mikio, 2011-05-20 09:19:10]

Hello bradfitz@golang.org, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-05-20 18:47:08]

http://codereview.appspot.com/4550062/diff/5001/src/pkg/net/ipsock.go
File src/pkg/net/ipsock.go (right):

http://codereview.appspot.com/4550062/diff/5001/src/pkg/net/ipsock.go#newcode62
src/pkg/net/ipsock.go:62: func favoriteAddrFamily(net string, raddr, laddr
sockaddr, mode string) int {
a mode string instead of an integer enum type is weird, but whatever.  looks
like you're already doing the "mode string" elsewhere.

http://codereview.appspot.com/4550062/diff/5001/src/pkg/net/ipsock.go#newcode72
src/pkg/net/ipsock.go:72: // If mode indicates "listen" and laddr.(type).IP is
nil,
This comment isn't really about the block of code just below.  Why don't you
move it up above "func favoriteAddrFamily" and explain the function as a whole a
bit too, including this block of text?

http://codereview.appspot.com/4550062/diff/5001/src/pkg/net/server_test.go
File src/pkg/net/server_test.go (right):

http://codereview.appspot.com/4550062/diff/5001/src/pkg/net/server_test.go#ne...
src/pkg/net/server_test.go:122: doTest(t, "tcp", "", "[::1]")
cool, nice new tests.

[mikio, 2011-05-21 09:10:47]

http://codereview.appspot.com/4550062/diff/5001/src/pkg/net/ipsock.go
File src/pkg/net/ipsock.go (right):

http://codereview.appspot.com/4550062/diff/5001/src/pkg/net/ipsock.go#newcode62
src/pkg/net/ipsock.go:62: func favoriteAddrFamily(net string, raddr, laddr
sockaddr, mode string) int {
On 2011/05/20 18:47:08, bradfitz wrote:
> a mode string instead of an integer enum type is weird, but whatever.  looks
> like you're already doing the "mode string" elsewhere.

this guy already took another string literal net and the caller of this function
 internetSocket did too. I'm not sure how efficient doing replace string to
integer is, do you have any preference?

http://codereview.appspot.com/4550062/diff/5001/src/pkg/net/ipsock.go#newcode72
src/pkg/net/ipsock.go:72: // If mode indicates "listen" and laddr.(type).IP is
nil,
On 2011/05/20 18:47:08, bradfitz wrote:
> This comment isn't really about the block of code just below.  Why don't you
> move it up above "func favoriteAddrFamily" and explain the function as a whole
a
> bit too, including this block of text?

Done.

[mikio, 2011-05-21 09:11:08]

Hello bradfitz@golang.org, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2011-05-22 16:48:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=16730ac430be ***

net: re-enable wildcard listening

Fixes issue 1854.

R=bradfitz, golang-dev
CC=golang-dev
http://codereview.appspot.com/4550062

Committer: Brad Fitzpatrick <bradfitz@golang.org>

[bradfitz, 2011-05-22 16:48:24]

LGTM

On Sat, May 21, 2011 at 2:11 AM, <mikioh.mikioh@gmail.com> wrote:

> Hello bradfitz@golang.org, golang-dev@googlegroups.com (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
> http://codereview.appspot.com/4550062/
>

[rsc1, 2011-05-31 19:39:42]

The test cannot do wildcard listening, at least not in short mode,
because then all.bash will cause Mac firewall popups.
Also I think it is bad form to listen on public ports, however
briefly, during the Go install.  I will send a CL.

Russ